New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear the password display after some time #86

Closed
karlgrz opened this Issue Aug 5, 2015 · 5 comments

Comments

Projects
None yet
2 participants
@karlgrz

karlgrz commented Aug 5, 2015

I briefly searched through the open and closed issues to see if this was already mentioned, so forgive me if I missed it.

I see the "Hide Password" and "Hide Content" options in Config, but what I think would be cool is if the password / content window respected the "Autoclear" option and duration.

For example, if I have "Autoclear" set to 25 seconds, and "Hide Password" and "Hide content" unchecked, it would be great if that panel was cleared out when the clipboard was cleared out.

If this is something that sounds good I'd love to give it a shot implementing it if you would point me in the right direction. I haven't touched C++ in ages, heh.

@annejan

This comment has been minimized.

Member

annejan commented Aug 5, 2015

I would prefer adding a separate checkbox (and number box) for this option.

In short adding a configurable feature requires you to:

  1. Add (private) variable(s) in mainwindow.h

  2. Add the stuff in dialog.cpp (and .h and .ui) for the config interface.

  3. In mainwindow.cpp read variables from settings in checkConfig method.
    In config set variables in dialog, read them back (after ok) and update settings.

  4. Use them new variables :-)

I think it's a smart thing to do this kind of thing in a separate branch in git.

@karlgrz

This comment has been minimized.

karlgrz commented Aug 5, 2015

Yea, definitely separate branch. Thanks for the pointers, I'll take a look and throw in the towel if the portion of my brain allocated to C++ is overflowed :-)

@annejan

This comment has been minimized.

Member

annejan commented Aug 5, 2015

A nice example is the first parts of 36507b9 from the templates branch . .
Just the basic boiler-plating for adding (in this case a whole new tab with) new configuration options and checkbox dependent enabling/disabling of a sub-option.

@karlgrz

This comment has been minimized.

karlgrz commented Aug 5, 2015

Alright, I've got something working, but it looks like *.o is in my commit. Need to clean that up and then I will submit pull request.

karlgrz pushed a commit to karlgrz/qtpass that referenced this issue Aug 6, 2015

annejan added a commit that referenced this issue Aug 6, 2015

Fixes: #86
Merge branch 'karlgrz-issue-86-clear-panel' into develop
@annejan

This comment has been minimized.

Member

annejan commented Aug 6, 2015

Nice work!

@annejan annejan closed this Aug 6, 2015

annejan added a commit that referenced this issue Jun 1, 2016

Fixes: #86
Merge branch 'karlgrz-issue-86-clear-panel' into develop
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment