New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore cmdline arguments if -session is used. #321

Merged
merged 1 commit into from Sep 11, 2017

Conversation

Projects
None yet
3 participants
@Achimh3011
Contributor

Achimh3011 commented Sep 8, 2017

Fixes #320

@Achimh3011

This comment has been minimized.

Contributor

Achimh3011 commented Sep 8, 2017

Sorry, referenced wrong issue in commit.

@coveralls

This comment has been minimized.

coveralls commented Sep 8, 2017

Coverage Status

Coverage decreased (-0.0004%) to 1.814% when pulling 0a9e20c on Achimh3011:patch-1 into b1816be on IJHack:master.

@codecov

This comment has been minimized.

codecov bot commented Sep 8, 2017

Codecov Report

Merging #321 into master will decrease coverage by 5.28%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #321      +/-   ##
=========================================
- Coverage    8.22%   2.93%   -5.29%     
=========================================
  Files          14      36      +22     
  Lines         961    2690    +1729     
  Branches      123     364     +241     
=========================================
  Hits           79      79              
- Misses        881    2610    +1729     
  Partials        1       1
Impacted Files Coverage Δ
src/main.cpp 0% <0%> (ø)
src/datahelpers.h 0% <0%> (ø) ⬆️
src/usersdialog.h 0% <0%> (ø)
src/configdialog.h 0% <0%> (ø)
src/qprogressindicator.h 0% <0%> (ø)
src/trayicon.h 0% <0%> (ø)
src/configdialog.cpp 0% <0%> (ø)
src/storemodel.h 0% <0%> (ø)
src/storemodel.cpp 0% <0%> (ø)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1816be...b03656f. Read the comment docs.

@Achimh3011 Achimh3011 force-pushed the Achimh3011:patch-1 branch from 0a9e20c to b03656f Sep 8, 2017

@coveralls

This comment has been minimized.

coveralls commented Sep 8, 2017

Coverage Status

Coverage decreased (-0.0004%) to 1.814% when pulling b03656f on Achimh3011:patch-1 into b1816be on IJHack:master.

1 similar comment
@coveralls

This comment has been minimized.

coveralls commented Sep 8, 2017

Coverage Status

Coverage decreased (-0.0004%) to 1.814% when pulling b03656f on Achimh3011:patch-1 into b1816be on IJHack:master.

@annejan annejan merged commit 91c51e0 into IJHack:master Sep 11, 2017

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
linthub Linthub has cleared the pull request, no code style suggestions found.
Details

@Achimh3011 Achimh3011 deleted the Achimh3011:patch-1 branch Sep 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment