New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to prevent the installer requesting admin #424

Merged
merged 1 commit into from Oct 24, 2018

Conversation

Projects
None yet
3 participants
@hughwilliams94
Copy link
Contributor

hughwilliams94 commented Oct 24, 2018

@codecov

This comment has been minimized.

Copy link

codecov bot commented Oct 24, 2018

Codecov Report

Merging #424 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #424   +/-   ##
======================================
  Coverage    7.25%   7.25%           
======================================
  Files          41      41           
  Lines        2662    2662           
======================================
  Hits          193     193           
  Misses       2469    2469

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f7046e...e11c8a5. Read the comment docs.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Oct 24, 2018

Coverage Status

Coverage remained the same at 7.26% when pulling e11c8a5 on hughwilliams94:patch-1 into 5f7046e on IJHack:master.

@annejan

This comment has been minimized.

Copy link
Member

annejan commented Oct 24, 2018

Thank you very much @hughwilliams94

@annejan annejan merged commit 32ea1ad into IJHack:master Oct 24, 2018

5 checks passed

CodeFactor No issues found.
Details
codecov/patch Coverage not affected when comparing 5f7046e...e11c8a5
Details
codecov/project 7.25% remains the same compared to 5f7046e
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@hughwilliams94

This comment has been minimized.

Copy link
Contributor

hughwilliams94 commented on e11c8a5 Oct 24, 2018

Apologies, I should have not have made this pull request. The build installs without admin, but fails to run.

This comment has been minimized.

Copy link
Member

annejan replied Oct 24, 2018

OK, no worries, I'll fire up my Windows VM and see what I can do (or rever).

This comment has been minimized.

Copy link
Member

annejan replied Oct 24, 2018

If you find a fix, feel free to make a pull request, because I doubt we really need admin rights.

This comment has been minimized.

Copy link
Contributor

hughwilliams94 replied Oct 24, 2018

It just seems to fail silently, the process briefly appears in Task Manager and there was an error message once but no details. I am running it on Win7 64 bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment