New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfixes and Windows compatibility improvements #430

Merged
merged 4 commits into from Dec 10, 2018

Conversation

Projects
None yet
3 participants
@mrsch
Copy link
Contributor

mrsch commented Nov 4, 2018

This should fix #400 and #205

Tested on Windows 10 and Arch Linux

mrsch added some commits Nov 4, 2018

Split keys on any newline character (line feed or carriage return)
actualKeys was empty on Windows because of extra carriage return characters.
PassStore path has to be normalized
Without this some string/path comparisons on windows (e.g. in
Pass::getRecipientList) would fail.
Fix deselect bug
After selection and deselection of a folder the currentDir did get set
to "/". After right clicking and selecting "Users" the root directory
would be used for all actions. For example when changing the Users and
reencrypting, all .gpg files in the system would get reencrypted.

@mrsch mrsch changed the title Bugfixes and Windows compatibility improvemets Bugfixes and Windows compatibility improvements Nov 4, 2018

@codecov

This comment has been minimized.

Copy link

codecov bot commented Nov 4, 2018

Codecov Report

Merging #430 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #430      +/-   ##
=========================================
- Coverage    7.25%   7.23%   -0.02%     
=========================================
  Files          41      41              
  Lines        2662    2666       +4     
=========================================
  Hits          193     193              
- Misses       2469    2473       +4
Impacted Files Coverage Δ
src/mainwindow.cpp 0% <0%> (ø) ⬆️
src/imitatepass.cpp 0.46% <0%> (ø) ⬆️
src/qtpasssettings.cpp 7.55% <0%> (-0.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32ea1ad...5b285eb. Read the comment docs.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Nov 4, 2018

Coverage Status

Coverage decreased (-0.007%) to 7.254% when pulling 5b285eb on mrsch:windows_fixes into 32ea1ad on IJHack:master.

@annejan annejan merged commit 8fabd7e into IJHack:master Dec 10, 2018

3 of 5 checks passed

codecov/patch 0% of diff hit (target 7.25%)
Details
codecov/project 7.23% (-0.02%) compared to 32ea1ad
Details
CodeFactor No issues found.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment