Bugfixes and Windows compatibility improvements #430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
actualKeys was empty on Windows because of extra carriage return characters.
Without this some string/path comparisons on windows (e.g. in Pass::getRecipientList) would fail.
After selection and deselection of a folder the currentDir did get set to "/". After right clicking and selecting "Users" the root directory would be used for all actions. For example when changing the Users and reencrypting, all .gpg files in the system would get reencrypted.
mrsch
changed the title
Codecov Report
@@ Coverage Diff @@
## master #430 +/- ##
=========================================
- Coverage 7.25% 7.23% -0.02%
=========================================
Files 41 41
Lines 2662 2666 +4
=========================================
Hits 193 193
- Misses 2469 2473 +4
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #400 and #205
Tested on Windows 10 and Arch Linux