Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing app ID and icon on Wayland. #468

Merged
merged 1 commit into from Aug 28, 2019

Conversation

@lightbulbjim
Copy link
Contributor

lightbulbjim commented Aug 27, 2019

X11/Wayland needs to know the name of the .desktop file to show a dock
icon and application name. X11 has various means of guessing the
filename (often WM_NAME). Wayland is a bit more strict, and requires
that either the filename match the AppId or the .desktop filename be
specified.

By specifying the .desktop filename QT will set the AppId automatically (from the Exec field I believe):

$ WAYLAND_DEBUG=1 ./result/bin/qtpass |& grep 'xdg_toplevel@[0-9]\+\.set_app_id'
[4110074.755]  -> xdg_toplevel@23.set_app_id("qtpass")

Tested on a Gnome 3.32 Wayland session. To run using XWayland, set QT_QPA_PLATFORM=xcb. To run using Wayland set QT_QPA_PLATFORM=wayland.

X11/Wayland needs to know the name of the .desktop file to show a dock
icon and application name. X11 has various means of guessing the
filename (often WM_NAME). Wayland is a bit more strict, and requires
that either the filename match the AppId or the .desktop filename be
specified.
@coveralls

This comment has been minimized.

Copy link

coveralls commented Aug 28, 2019

Coverage Status

Coverage decreased (-0.008%) to 7.001% when pulling aba8c41 on lightbulbjim:wayland-appid into 9a15ef3 on IJHack:master.

@codecov

This comment has been minimized.

Copy link

codecov bot commented Aug 28, 2019

Codecov Report

Merging #468 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #468      +/-   ##
=========================================
- Coverage    7.41%   7.41%   -0.01%     
=========================================
  Files          44      44              
  Lines        2765    2766       +1     
=========================================
  Hits          205     205              
- Misses       2560    2561       +1
Impacted Files Coverage Δ
main/main.cpp 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a15ef3...aba8c41. Read the comment docs.

@annejan annejan merged commit 1087ad7 into IJHack:master Aug 28, 2019
3 of 5 checks passed
3 of 5 checks passed
codecov/patch 0% of diff hit (target 7.41%)
Details
codecov/project 7.41% (-0.01%) compared to 9a15ef3
Details
CodeFactor No issues found.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@lightbulbjim lightbulbjim mentioned this pull request Aug 28, 2019
6 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.