qtpass: 1.2.3 -> 1.3.0

[lightbulbjim]

Motivation for this change

Updating to latest version. Also includes a patch to fix the missing app icon under Wayland (see IJHack/QtPass#468)

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Determined the impact on package closure size (by running nix path-info -S before and after)
• Ensured that relevant documentation is up to date
• Fits CONTRIBUTING.md.

Notify maintainers

cc @hrdinka

[Ma27]

@GrahamcOfBorg build qtpass

[jonringer]

I see to just get a segfault when running this.

[nix-shell:~/.cache/nix-review/pr-67660]$ ./results/qtpass/bin/qtpass
Segmentation fault

[Ma27]

@jonringer could you please providing e.g. an strace log about the issue? I just tested this localy and didn't encounter any issues :)

[jonringer]

Sure, strace logs:

last 50ish lines

mmap(NULL, 53312, PROT_READ|PROT_EXEC, MAP_PRIVATE|MAP_DENYWRITE, 7, 0) = 0x7f79985fc000
mprotect(0x7f7998607000, 4096, PROT_NONE) = 0
mmap(0x7f7998608000, 8192, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_DENYWRITE, 7, 0xb000) = 0x7f7998608000
close(7)                                = 0
mprotect(0x7f7998608000, 4096, PROT_READ) = 0
access("/nix/store/vwcxfvl2p0rnw2w6lqa2ax0wbcahlsss-bash-interactive-4.4-p23/lib/qt-5.12.0/plugins/styles/.", F_OK) = -1 ENOENT (No such file or directory)
access("/nix/store/f9f5c3x08xy92x5zh2fqi5m7gv0309a4-patchelf-0.9/lib/qt-5.12.0/plugins/styles/.", F_OK) = -1 ENOENT (No such file or directory)
access("/nix/store/hpzj855nkgjvg58nrhq4910sb9q3kss1-gcc-wrapper-7.4.0/lib/qt-5.12.0/plugins/styles/.", F_OK) = -1 ENOENT (No such file or directory)
access("/nix/store/wr5dlcw1asw8dwgm4bwjmga8f52m5lfx-gcc-7.4.0/lib/qt-5.12.0/plugins/styles/.", F_OK) = -1 ENOENT (No such file or directory)
access("/nix/store/lcpf5mzc4f1scj67znarbd6kg64lykls-glibc-2.27-bin/lib/qt-5.12.0/plugins/styles/.", F_OK) = -1 ENOENT (No such file or directory)
access("/nix/store/k8lhqzpaaymshchz8ky3z4653h4kln9d-coreutils-8.31/lib/qt-5.12.0/plugins/styles/.", F_OK) = -1 ENOENT (No such file or directory)
access("/nix/store/hsi8wy263vimgvr4nf2hvf9gx661qkvj-binutils-wrapper-2.31.1/lib/qt-5.12.0/plugins/styles/.", F_OK) = -1 ENOENT (No such file or directory)
access("/nix/store/mgdjnsrkqgmxqjaqaxgqyqm7fwyi96fk-binutils-2.31.1/lib/qt-5.12.0/plugins/styles/.", F_OK) = -1 ENOENT (No such file or directory)
access("/nix/store/xr45g8hywhg4v51nz09dnc26b3acpdjm-qtpass-1.3.0/lib/qt-5.12.0/plugins/styles/.", F_OK) = -1 ENOENT (No such file or directory)
access("/nix/store/gjh3a8hqic3bqc2xzj8g2qxwz81wfjxx-findutils-4.6.0/lib/qt-5.12.0/plugins/styles/.", F_OK) = -1 ENOENT (No such file or directory)
access("/nix/store/jpjl3wzxlw1ihfzgk9bx4pv01py5rk3g-diffutils-3.7/lib/qt-5.12.0/plugins/styles/.", F_OK) = -1 ENOENT (No such file or directory)
access("/nix/store/vnyd3wh5i5kj66n9c5b8shzxjjrw22cn-gnused-4.7/lib/qt-5.12.0/plugins/styles/.", F_OK) = -1 ENOENT (No such file or directory)
access("/nix/store/agcay3wmf74qinwshnjqy73w8rxf82hs-gnugrep-3.3/lib/qt-5.12.0/plugins/styles/.", F_OK) = -1 ENOENT (No such file or directory)
access("/nix/store/5x5a1bb8rk317z5l1824j84nwmmd5w52-gawk-4.2.1/lib/qt-5.12.0/plugins/styles/.", F_OK) = -1 ENOENT (No such file or directory)
access("/nix/store/xnk229qan97prxmwfsgm65py2qpca109-gnutar-1.32/lib/qt-5.12.0/plugins/styles/.", F_OK) = -1 ENOENT (No such file or directory)
access("/nix/store/rgb9bhwzwijg87jy1kcd88ixdzg91hjy-gzip-1.10/lib/qt-5.12.0/plugins/styles/.", F_OK) = -1 ENOENT (No such file or directory)
access("/nix/store/klwm2bm1jxaqnn4x8gikqxcd43zc7hd3-bzip2-1.0.6.0.1-bin/lib/qt-5.12.0/plugins/styles/.", F_OK) = -1 ENOENT (No such file or directory)
access("/nix/store/6g1vx8239mrxa1apicld1nbihminadsx-gnumake-4.2.1/lib/qt-5.12.0/plugins/styles/.", F_OK) = -1 ENOENT (No such file or directory)
access("/nix/store/xfghy8ixrhz3kyy6p724iv3cxji088dx-bash-4.4-p23/lib/qt-5.12.0/plugins/styles/.", F_OK) = -1 ENOENT (No such file or directory)
access("/nix/store/snf5d0lv35bsjyhqj4a1alklzsgj4ppr-patch-2.7.6/lib/qt-5.12.0/plugins/styles/.", F_OK) = -1 ENOENT (No such file or directory)
access("/nix/store/7y1afcqr7zw2p8cz7yhkyf3xb3ss1f32-xz-5.2.4-bin/lib/qt-5.12.0/plugins/styles/.", F_OK) = -1 ENOENT (No such file or directory)
access("/nix/store/1ns1zln608r5kma87rvw5kj76sckzdvn-nix-2.2.2/lib/qt-5.12.0/plugins/styles/.", F_OK) = -1 ENOENT (No such file or directory)
access("/nix/store/ccl7j6yhkz0x5gf4vyxll824d5hzgayw-git-2.19.2/lib/qt-5.12.0/plugins/styles/.", F_OK) = -1 ENOENT (No such file or directory)
access("/nix/store/dwi186iqm6p3kfncfsl62fbfwfry1yci-python3-3.7.3/lib/qt-5.12.0/plugins/styles/.", F_OK) = -1 ENOENT (No such file or directory)
access("/nix/store/8l7hm7bryb9aqdzv96ca5hap5nv7j9ia-nix-review-2.0.1/lib/qt-5.12.0/plugins/styles/.", F_OK) = -1 ENOENT (No such file or directory)
access("/nix/store/gzp169g8012kmrwbl2iyssyli3l73dgq-python3.7-setuptools-40.8.0/lib/qt-5.12.0/plugins/styles/.", F_OK) = -1 ENOENT (No such file or directory)
access("/home/jon/lib/qt-5.12.0/plugins/styles/.", F_OK) = -1 ENOENT (No such file or directory)
access("/run/wrappers/lib/qt-5.12.0/plugins/styles/.", F_OK) = -1 ENOENT (No such file or directory)
access("/home/jon/.nix-profile/lib/qt-5.12.0/plugins/styles/.", F_OK) = -1 ENOENT (No such file or directory)
access("/nix/var/nix/profiles/default/lib/qt-5.12.0/plugins/styles/.", F_OK) = -1 ENOENT (No such file or directory)
access("/run/current-system/sw/lib/qt-5.12.0/plugins/styles/.", F_OK) = -1 ENOENT (No such file or directory)
access("/etc/profiles/per-user/jon/lib/qt-5.12.0/plugins/styles/.", F_OK) = -1 ENOENT (No such file or directory)
access("/home/jon/.cargo/lib/qt-5.12.0/plugins/styles/.", F_OK) = -1 ENOENT (No such file or directory)
access("/nix/store/37hqhqzkgfkqc22xicbjcvk7zp3wln1n-git-2.22.0/lib/qt-5.12.0/plugins/styles/.", F_OK) = -1 ENOENT (No such file or directory)
access("/nix/store/nnynljhzvsai7h0ip1c436i9qvr21pjc-gnupg-2.2.17/lib/qt-5.12.0/plugins/styles/.", F_OK) = -1 ENOENT (No such file or directory)
access("/nix/store/ipdrn63hj3n8m2cz2i15kvgm8rb608nk-password-store-1.7.3/lib/qt-5.12.0/plugins/styles/.", F_OK) = -1 ENOENT (No such file or directory)
access("/nix/store/b4xs11la0i2hsx3j447l2mcpplcqbvgj-qtwayland-5.12.0-bin/lib/qt-5.12.0/plugins/styles/.", F_OK) = -1 ENOENT (No such file or directory)
access("/nix/store/00bn4b6njypnz75nwd0hm6zsaj4m3l9l-qtdeclarative-5.12.0-bin/lib/qt-5.12.0/plugins/styles/.", F_OK) = -1 ENOENT (No such file or directory)
access("/nix/store/qw9dhpi7hrv40ca333lh7mq5jshqzc15-qtsvg-5.12.0-bin/lib/qt-5.12.0/plugins/styles/.", F_OK) = -1 ENOENT (No such file or directory)
access("/nix/store/vll8433ddlpkmhk5k13zzg79glamj50q-qtbase-5.12.0-bin/lib/qt-5.12.0/plugins/styles/.", F_OK) = -1 ENOENT (No such file or directory)
access("/nix/store/xr45g8hywhg4v51nz09dnc26b3acpdjm-qtpass-1.3.0/bin/styles/.", F_OK) = -1 ENOENT (No such file or directory)
lstat("/run", {st_mode=S_IFDIR|0755, st_size=660, ...}) = 0
lstat("/run/user", {st_mode=S_IFDIR|0755, st_size=60, ...}) = 0
lstat("/run/user/1000", {st_mode=S_IFDIR|0700, st_size=380, ...}) = 0
lstat("/run", {st_mode=S_IFDIR|0755, st_size=660, ...}) = 0
lstat("/run/user", {st_mode=S_IFDIR|0755, st_size=60, ...}) = 0
lstat("/run/user/1000", {st_mode=S_IFDIR|0700, st_size=380, ...}) = 0
openat(AT_FDCWD, "/run/user/1000/qipc_systemsem_jonQtPass5ab7b427fccc0602e0fd90ae53f615c765be1cef", O_RDWR|O_CREAT|O_EXCL|O_CLOEXEC, 0640) = -1 EEXIST (File exists)
stat("/run/user/1000/qipc_systemsem_jonQtPass5ab7b427fccc0602e0fd90ae53f615c765be1cef", {st_mode=S_IFREG|0640, st_size=0, ...}) = 0
semget(0x512f6129, 1, IPC_CREAT|IPC_EXCL|0600) = -1 EEXIST (File exists)
semget(0x512f6129, 1, IPC_CREAT|0600)   = 196609
semop(196609, [{0, -1, SEM_UNDO}], 1)   = 0
access("/run/user/1000/qipc_sharedmemory_jonQtPass5ab7b427fccc0602e0fd90ae53f615c765be1cef", F_OK) = 0
stat("/run/user/1000/qipc_sharedmemory_jonQtPass5ab7b427fccc0602e0fd90ae53f615c765be1cef", {st_mode=S_IFREG|0640, st_size=0, ...}) = 0
shmget(0x512f612a, 0, 0600)             = 594083856
shmat(594083856, NULL, 0)               = 0x7f79985fb000
shmctl(594083856, IPC_STAT, {shm_perm={uid=1000, gid=100, mode=0600, key=1362059562, cuid=1000, cgid=100}, shm_segsz=1, shm_cpid=32382, shm_lpid=5492, shm_nattch=1, shm_atime=1567036310, shm_dtime=1567036075, shm_ctime=1567036075}) = 0
semop(196609, [{0, 1, SEM_UNDO}], 1)    = 0
semop(196609, [{0, -1, SEM_UNDO}], 1)   = 0
shmdt(0x7f79985fb000)                   = 0
shmget(0x512f612a, 0, 0400)             = 594083856
shmctl(594083856, IPC_STAT, {shm_perm={uid=1000, gid=100, mode=0600, key=1362059562, cuid=1000, cgid=100}, shm_segsz=1, shm_cpid=32382, shm_lpid=5492, shm_nattch=0, shm_atime=1567036310, shm_dtime=1567036310, shm_ctime=1567036075}) = 0
shmctl(594083856, IPC_RMID, 0x7ffe6e5b3a40) = 0
unlink("/run/user/1000/qipc_sharedmemory_jonQtPass5ab7b427fccc0602e0fd90ae53f615c765be1cef") = 0
semop(196609, [{0, 1, SEM_UNDO}], 1)    = 0
openat(AT_FDCWD, "/sys/devices/system/cpu/online", O_RDONLY|O_CLOEXEC) = 7
read(7, "0-7\n", 8192)                  = 4
close(7)                                = 0
poll([{fd=4, events=POLLIN|POLLOUT}], 1, -1) = 1 ([{fd=4, revents=POLLOUT}])
writev(4, [{iov_base="\1\0\10\0\5\0 \1F\1\0\0\0\0\0\0\1\0\1\0\0\0\2\0!\0\0\0\0\0\0\0"..., iov_len=84}], 1) = 84
futex(0x827000, FUTEX_WAIT_PRIVATE, 0, NULL) = 0
futex(0x826fb0, FUTEX_WAKE_PRIVATE, 1)  = 0
poll([{fd=4, events=POLLIN|POLLOUT}], 1, -1) = 1 ([{fd=4, revents=POLLOUT}])
writev(4, [{iov_base=".\0\2\0\3\0 \1", iov_len=8}], 1) = 8
poll([{fd=4, events=POLLIN|POLLOUT}], 1, -1) = 1 ([{fd=4, revents=POLLOUT}])
writev(4, [{iov_base="<\0\2\0\0\0 \1+\0\1\0", iov_len=12}, {iov_base=NULL, iov_len=0}, {iov_base="", iov_len=0}], 3) = 12
poll([{fd=4, events=POLLIN}], 1, -1)    = 1 ([{fd=4, revents=POLLIN}])
recvmsg(4, {msg_name=NULL, msg_namelen=0, msg_iov=[{iov_base="\1\1\227\1\0\0\0\0\2\0\340\2\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0", iov_len=4096}], msg_iovlen=1, msg_controllen=0, msg_flags=0}, 0) = 32
shutdown(4, SHUT_RDWR)                  = 0
close(4)                                = 0
getpid()                                = 5492
close(3)                                = 0
exit_group(0)                           = ?
+++ exited with 0 +++

[lightbulbjim]

I can't reproduce the segfault. It's working fine for me.

[teto]

worked fine for me in nix-review on unstable. Even if it crashed, might be more of a program bug so I believe we can merge.

[worldofpeace]

Works for me and my password store under x11.