Layout/Page: Check for new introduced block (Mantis 32455) #4399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mjansenDatabay thx a lot. @mjansenDatabay and @Amstutz hat a short exchange on this. We agree that we will not merge this, since the actual issue (missing metadata in the metadata section of the HTML document), which has been fixed with the latest changes, will still persist and nobody will be aware of it. See https://mantis.ilias.de/view.php?id=32455 for details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mantis Issue: https://mantis.ilias.de/view.php?id=32455
I don't necessarily suggest to merge this PR, because the changed code will "silence" the actual issue of missing metadata in the HTML document of ILIAS.