Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using page object design to organise our e2e test #123

Closed
DedrickEnc opened this issue Feb 22, 2016 · 3 comments
Closed

Using page object design to organise our e2e test #123

DedrickEnc opened this issue Feb 22, 2016 · 3 comments

Comments

@DedrickEnc
Copy link
Contributor

The page object design is very recommended when reading the protractor documentation.
It let you write clear test and very maintainable, it also let you reuse a page object some where else when necessary.

I applied this design to the project test and it was a success, I will walk through other test file to apply this design, see here for more information.
What do you think?
@IMA-WorldHealth/local-contributors
@jniles
Copy link
Collaborator

jniles commented Feb 22, 2016

We are already doing something similar. See FormUtils.

@lomamech has been using this quite successfully.

@jniles
Copy link
Collaborator

jniles commented Feb 22, 2016

Oh! That is also what the "test wrappers" for our components are supposed to do. That is why we cannot accept components without a tests written for them.

@jniles jniles mentioned this issue Mar 11, 2016
Merged
@jniles
Copy link
Collaborator

jniles commented Apr 17, 2016

Closing this as implemented in #189 and #143.

@jniles jniles closed this as completed Apr 17, 2016
@jniles jniles mentioned this issue May 24, 2016
Closed
jniles referenced this issue in jniles/bhima Jan 12, 2017
fix(patients): order by registration_date
6c9488f 
This commit orders the patients found using the `find()` method by
registration date.

Closes #123.
jniles referenced this issue in jniles/bhima Jan 12, 2017
fix(cash): make registry order by date
dcbf6d0 
This commit fixes the date ordering for the cash registry.  It fixes the
problem reported in #123.
jniles referenced this issue in jniles/bhima Jan 12, 2017
fix(patients): order by registration_date
36439df 
This commit orders the patients found using the `find()` method by
registration date.

Closes #123.
jniles referenced this issue in jniles/bhima Jan 12, 2017
fix(cash): make registry order by date
dbaaa4d 
This commit fixes the date ordering for the cash registry.  It fixes the
problem reported in #123.
jniles referenced this issue in jniles/bhima Jan 12, 2017
@jniles
fix(patients): order by registration_date
c70ff0b 
This commit orders the patients found using the `find()` method by
registration date.

Closes #123.
jniles referenced this issue in jniles/bhima Jan 12, 2017
@jniles
fix(cash): make registry order by date
f0956d6 
This commit fixes the date ordering for the cash registry.  It fixes the
problem reported in #123.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jniles @DedrickEnc