Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: Stock Movements Registry does not sort "cost" as a number #2073

Closed
jniles opened this issue Sep 2, 2017 · 0 comments · Fixed by #2074
Closed

bug: Stock Movements Registry does not sort "cost" as a number #2073

jniles opened this issue Sep 2, 2017 · 0 comments · Fixed by #2074
Assignees
@jniles
Labels
Bug

Comments

@jniles
Copy link
Contributor

jniles commented Sep 2, 2017

The Stock Movements Registry does not sort the cost column as a number. This is due to a lack of type:number on the grid options.
@jniles jniles added the Bug label Sep 2, 2017
@jniles jniles self-assigned this Sep 2, 2017
jniles added a commit to jniles/bhima that referenced this issue Sep 2, 2017
@jniles
fix(stock): improve movements registry
999693e 
This commit fixes a number of bugs on the movements registry.
 1. The input/output search parameter now actually filters correctly.
 2. The "reason" ui-select actually filters the registry.
 3. The "actions" column does not present a dropdown on header rows.
 4. The date and unit cost columns sort properly.
 5. The grid footer no longer gives untranslated english text in the
 footer.

It also improves the performance of the registry by pre-computing costs
in the same way that it pre-computes the flux mappings.

Closes IMA-WorldHealth#2073.  Closes IMA-WorldHealth#2072.
jniles added a commit to jniles/bhima that referenced this issue Sep 2, 2017
@jniles
fix(stock): improve movements registry
74be7ca 
This commit fixes a number of bugs on the movements registry.
 1. The input/output search parameter now actually filters correctly.
 2. The "reason" ui-select actually filters the registry.
 3. The "actions" column does not present a dropdown on header rows.
 4. The date and unit cost columns sort properly.
 5. The grid footer no longer gives untranslated english text in the
 footer.

It also improves the performance of the registry by pre-computing costs
in the same way that it pre-computes the flux mappings.

Closes IMA-WorldHealth#2073.  Closes IMA-WorldHealth#2072.
@jniles jniles mentioned this issue Sep 2, 2017
Merged
4 tasks
jniles added a commit to jniles/bhima that referenced this issue Sep 2, 2017
@jniles
fix(stock): improve movements registry
c9a4f97 
This commit fixes a number of bugs on the movements registry.
 1. The input/output search parameter now actually filters correctly.
 2. The "reason" ui-select actually filters the registry.
 3. The "actions" column does not present a dropdown on header rows.
 4. The date and unit cost columns sort properly.
 5. The grid footer no longer gives untranslated english text in the
 footer.

It also improves the performance of the registry by pre-computing costs
in the same way that it pre-computes the flux mappings.

Closes IMA-WorldHealth#2073.  Closes IMA-WorldHealth#2072.
jniles added a commit to jniles/bhima that referenced this issue Sep 2, 2017
@jniles
fix(stock): improve movements registry
f2ec4e8 
This commit fixes a number of bugs on the movements registry.
 1. The input/output search parameter now actually filters correctly.
 2. The "reason" ui-select actually filters the registry.
 3. The "actions" column does not present a dropdown on header rows.
 4. The date and unit cost columns sort properly.
 5. The grid footer no longer gives untranslated english text in the
 footer.

It also improves the performance of the registry by pre-computing costs
in the same way that it pre-computes the flux mappings.

Closes IMA-WorldHealth#2073.  Closes IMA-WorldHealth#2072.
jniles added a commit to jniles/bhima that referenced this issue Sep 2, 2017
@jniles
fix(stock): improve movements registry
108c4d1 
This commit fixes a number of bugs on the movements registry.
 1. The input/output search parameter now actually filters correctly.
 2. The "reason" ui-select actually filters the registry.
 3. The "actions" column does not present a dropdown on header rows.
 4. The date and unit cost columns sort properly.
 5. The grid footer no longer gives untranslated english text in the
 footer.

It also improves the performance of the registry by pre-computing costs
in the same way that it pre-computes the flux mappings.

Closes IMA-WorldHealth#2073.  Closes IMA-WorldHealth#2072.
jniles added a commit to jniles/bhima that referenced this issue Sep 4, 2017
@jniles
fix(stock): improve movements registry
b4af85d 
This commit fixes a number of bugs on the movements registry.
 1. The input/output search parameter now actually filters correctly.
 2. The "reason" ui-select actually filters the registry.
 3. The "actions" column does not present a dropdown on header rows.
 4. The date and unit cost columns sort properly.
 5. The grid footer no longer gives untranslated english text in the
 footer.

It also improves the performance of the registry by pre-computing costs
in the same way that it pre-computes the flux mappings.

Closes IMA-WorldHealth#2073.  Closes IMA-WorldHealth#2072.
bors bot added a commit that referenced this issue Sep 4, 2017
@bors
Merge #2074
6da7ade 
2074: fix(stock): improve movements registry r=DedrickEnc a=jniles

This commit fixes a number of bugs on the movements registry.
 1. The input/output search parameter now actually filters correctly.
 2. The "reason" ui-select actually filters the registry.
 3. The "actions" column does not present a dropdown on header rows.
 4. The date and unit cost columns sort properly.
 5. The grid footer no longer gives untranslated english text in the
 footer.

It also improves the performance of the registry by pre-computing costs
in the same way that it pre-computes the flux mappings.

Closes #2073.  Closes #2072.

---
bors bot added a commit that referenced this issue Sep 5, 2017
@bors
Merge #2074
57a5abf 
2074: fix(stock): improve movements registry r=jniles a=jniles

This commit fixes a number of bugs on the movements registry.
 1. The input/output search parameter now actually filters correctly.
 2. The "reason" ui-select actually filters the registry.
 3. The "actions" column does not present a dropdown on header rows.
 4. The date and unit cost columns sort properly.
 5. The grid footer no longer gives untranslated english text in the
 footer.

It also improves the performance of the registry by pre-computing costs
in the same way that it pre-computes the flux mappings.

Closes #2073.  Closes #2072.

---
@bors bors bot closed this as completed in #2074 Sep 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jniles jniles

Labels
Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(stock): improve movements registry jniles/bhima
1 participant
@jniles