Skip to content

Commit

Permalink
fix(journal): ensure that data callbacks disable cellNav (#1517)
Browse files Browse the repository at this point in the history
This commit makes sure that the Posting Journal's datachange callbacks are run after the columns are
modified.

Closes #1495.
  • Loading branch information
jniles committed Apr 19, 2017
1 parent d27d615 commit 55f86b8
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion client/src/js/services/grid/TransactionService.js
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ function TransactionService($timeout, util, uiGridConstants, bhConstants, Notify

// sets the allowCellFocus parameter on grid's column definitions
function setColumnCellNav(column) {
column.allowCellFocus = this._cellNavEnabled;
column.allowCellFocus = !!this._cellNavEnabled;
}

// called after the cellNavigationEnabled trigger is fired
Expand Down Expand Up @@ -139,6 +139,9 @@ function TransactionService($timeout, util, uiGridConstants, bhConstants, Notify
});

this.disableCellNavigation();

api.grid.notifyDataChange(uiGridConstants.dataChange.COLUMN);
api.grid.notifyDataChange(uiGridConstants.dataChange.OPTIONS);
}.bind(this), MAGIC_NUMBER);
}.bind(this));
}
Expand Down

0 comments on commit 55f86b8

Please sign in to comment.