(bug) Posting Journal's cellNav should be disabled when not in Editing State. #1495
Assignees
Labels
Comments
|
I'll take this one. |
jniles
pushed a commit
to jniles/bhima
that referenced
this issue
Apr 18, 2017
This commit makes sure that the Posting Journal's datachange callbacks are run after the columns are modified. Closes IMA-WorldHealth#1495.
4 tasks
jniles
pushed a commit
to jniles/bhima
that referenced
this issue
Apr 18, 2017
This commit makes sure that the Posting Journal's datachange callbacks are run after the columns are modified. Closes IMA-WorldHealth#1495.
ghost
pushed a commit
that referenced
this issue
Apr 18, 2017
…l, r=jniles fix(journal): ensure that data callbacks disable cellNav This commit makes sure that the Posting Journal's dataChange callbacks are run after the columns are modified. Closes #1495. Addresses #1500. ---- Thank you for contributing! Before submitting this pull request, please verify that you have: - [x] Run your code through ESLint. [Check out our styleguide](https://github.com/IMA-WorldHealth/bhima-2.X/blob/master/docs/STYLEGUIDE.md). - [x] Run integration tests. - [x] Run end-to-end tests. - [x] Accurately described the changes your are making in this pull request. For a more detailed checklist, [see the official review checklist](https://docs.google.com/document/d/1nupLVLRXgSZJQo_acLgrwvPnN8RukfSiwRhSToj81uU/pub) that this PR will be evaluated against. Ensuring that the above checkboxes are completed will help speed the review process and help build a stronger application. Thanks!
ghost
pushed a commit
that referenced
this issue
Apr 19, 2017
…l, r=jniles fix(journal): ensure that data callbacks disable cellNav This commit makes sure that the Posting Journal's dataChange callbacks are run after the columns are modified. Closes #1495. Addresses #1500. ---- Thank you for contributing! Before submitting this pull request, please verify that you have: - [x] Run your code through ESLint. [Check out our styleguide](https://github.com/IMA-WorldHealth/bhima-2.X/blob/master/docs/STYLEGUIDE.md). - [x] Run integration tests. - [x] Run end-to-end tests. - [x] Accurately described the changes your are making in this pull request. For a more detailed checklist, [see the official review checklist](https://docs.google.com/document/d/1nupLVLRXgSZJQo_acLgrwvPnN8RukfSiwRhSToj81uU/pub) that this PR will be evaluated against. Ensuring that the above checkboxes are completed will help speed the review process and help build a stronger application. Thanks!
ghost
pushed a commit
that referenced
this issue
Apr 19, 2017
…l, r=jniles fix(journal): ensure that data callbacks disable cellNav This commit makes sure that the Posting Journal's dataChange callbacks are run after the columns are modified. Closes #1495. Addresses #1500. ---- Thank you for contributing! Before submitting this pull request, please verify that you have: - [x] Run your code through ESLint. [Check out our styleguide](https://github.com/IMA-WorldHealth/bhima-2.X/blob/master/docs/STYLEGUIDE.md). - [x] Run integration tests. - [x] Run end-to-end tests. - [x] Accurately described the changes your are making in this pull request. For a more detailed checklist, [see the official review checklist](https://docs.google.com/document/d/1nupLVLRXgSZJQo_acLgrwvPnN8RukfSiwRhSToj81uU/pub) that this PR will be evaluated against. Ensuring that the above checkboxes are completed will help speed the review process and help build a stronger application. Thanks!
jniles
pushed a commit
to jniles/bhima
that referenced
this issue
Apr 19, 2017
This commit makes sure that the Posting Journal's datachange callbacks are run after the columns are modified. Closes IMA-WorldHealth#1495.
jniles
pushed a commit
to jniles/bhima
that referenced
this issue
Apr 19, 2017
This commit makes sure that the Posting Journal's datachange callbacks are run after the columns are modified. Closes IMA-WorldHealth#1495.
jniles
added a commit
that referenced
this issue
Apr 19, 2017
This commit makes sure that the Posting Journal's datachange callbacks are run after the columns are modified. Closes #1495.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The
cellNavfeature is very useful during editing, but not very helpful when not editing. It traps the mouse and makes it so that you cannot unselect text you've highlighted unless you click outside of the Journal. It also captures click on theui-grid-selectioncolumn and the styling conflicts with the row selection. This is a really poor user experience.We should ensure that the
ui-gridcellNavfeature is only enabled during ui-grid editing on the Posting Journal for the best experience.The text was updated successfully, but these errors were encountered: