Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translations are broken on the client report #2366

Closed
jniles opened this issue Dec 8, 2017 · 1 comment · Fixed by #2369
Closed

Translations are broken on the client report #2366

jniles opened this issue Dec 8, 2017 · 1 comment · Fixed by #2369
Assignees
@jniles
Labels
Bug

Comments

@jniles
Copy link
Collaborator

jniles commented Dec 8, 2017

The client report has many broken translation keys. This makes the report almost unreadable. It would be nice if someone could fill out or correct the missing translations.
@jniles jniles self-assigned this Dec 9, 2017
@jniles
Copy link
Collaborator Author

jniles commented Dec 9, 2017

I got this one.

@jniles jniles added the Bug label Dec 9, 2017
jniles added a commit to jniles/bhima that referenced this issue Dec 9, 2017
@jniles
fix(reports): clients report misc fixes
88475e8 
This commit fixes a few bugs on the clients report:
 1. The i18n translations are now well defined.
 2. The currency is now rendered in the enterprise currency.

Closes IMA-WorldHealth#2366.
@jniles jniles mentioned this issue Dec 9, 2017
Merged
bors bot added a commit that referenced this issue Dec 9, 2017
@bors
Merge #2369
3913966 
2369: Fix misc fixes r=jniles a=jniles

This PR contains many bug fixes.
 1.  It fixes the date filtering in the Patients Registry.  This bug was due to a typo.
 2. It fixes both the i18n and the currency rendering in the Clients Report.
 3. It adds the balance to the Account Statement module.

Closes #2366.
@bors bors bot closed this as completed in #2369 Dec 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jniles jniles

Labels
Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix misc fixes jniles/bhima
1 participant
@jniles