Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break global "reports" folder into separate "reports" subfolders in each module #4146

Closed
jniles opened this issue Jan 29, 2020 · 5 comments · Fixed by #4737
Closed

Break global "reports" folder into separate "reports" subfolders in each module #4146

jniles opened this issue Jan 29, 2020 · 5 comments · Fixed by #4737

Comments

@jniles
Copy link
Contributor

jniles commented Jan 29, 2020

We currently have a global "reports" folder that is getting quite large. We have a total of 41 reports in the report table. Most of these reports are quite specialized - finance, stock, or medical.

To better manage our reports, we should break them up into separate folders for each component. For example, we would have

- Finance
   - Reports
- Medical
   - Reports
- Inventory
   - Reports

This would also make it easier to manage permissions to the different reports, since we wouldn't have stock reports visible if there were no stock modules enabled.

@jniles
Copy link
Contributor Author

jniles commented Jun 26, 2020

@lomamech can you look into this?

@jniles
Copy link
Contributor Author

jniles commented Jul 16, 2020

@kwilu claim

jniles added a commit to jniles/bhima that referenced this issue Jul 17, 2020
Adds subfolders for reports to each top-level module.

Closes IMA-WorldHealth#4146
jniles added a commit to jniles/bhima that referenced this issue Jul 17, 2020
Adds subfolders for reports to each top-level module.

Closes IMA-WorldHealth#4146
jniles added a commit to jniles/bhima that referenced this issue Jul 17, 2020
Adds subfolders for reports to each top-level module.

Closes IMA-WorldHealth#4146
jniles added a commit to jniles/bhima that referenced this issue Jul 17, 2020
Adds subfolders for reports to each top-level module.

Closes IMA-WorldHealth#4146
@jmcameron
Copy link
Collaborator

Not sure what you meant by:

  • Finance
    • Reports
  • Medical
    • Reports
  • Inventory
    • Reports

It seems like these are all under the "Reports" top-level menu item. Shouldn't this be:

  • Reports
    • Finance
      • Rep F1
      • Rep F2
    • Medical
      - Rep M1
      - Rep M2

etc?

@jmcameron
Copy link
Collaborator

Ok, do you mean to move the Reports for Finance under the top-level menu item "Finance"? etc?

jniles added a commit to jniles/bhima that referenced this issue Jul 20, 2020
Adds subfolders for reports to each top-level module.

Closes IMA-WorldHealth#4146
jniles added a commit to jniles/bhima that referenced this issue Jul 22, 2020
Adds subfolders for reports to each top-level module.

Closes IMA-WorldHealth#4146
jniles added a commit to jniles/bhima that referenced this issue Jul 23, 2020
Adds subfolders for reports to each top-level module.

Closes IMA-WorldHealth#4146
jniles added a commit to jniles/bhima that referenced this issue Jul 24, 2020
Adds subfolders for reports to each top-level module.

Closes IMA-WorldHealth#4146
@jniles
Copy link
Contributor Author

jniles commented Jul 26, 2020

@jmcameron apologies for not responding, I didn't see this.

Yeah, basically there should no longer be a generic "reports" folder, instead there should be many "reports" subfolders in each section. That way, if we install only stock management, for example, we only need to have "inventory", "purchases" and "stock" as top level folders ... and all of those will contain their respective reports.

It should make it much easier to find reports in the future.

bors bot added a commit that referenced this issue Jul 28, 2020
4737: chore: add subfolders for reports r=mbayopanda a=jniles

Adds subfolders for reports to each top-level module.

Closes #4146

Co-authored-by: Jonathan Niles <jonathanwniles@gmail.com>
@bors bors bot closed this as completed in c25f642 Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants