Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review Filtering the Posting Journal #840

Closed
1 of 2 tasks
sfount opened this issue Nov 2, 2016 · 1 comment
Closed
1 of 2 tasks

Review Filtering the Posting Journal #840

sfount opened this issue Nov 2, 2016 · 1 comment

Comments

@sfount
Copy link
Contributor

sfount commented Nov 2, 2016 •
edited by jniles
Loading

We currently have very basic filtering on the posting journal. As this module will be used frequently to search for and manipulate transactions, this should be iterated on. This issue will track that development.

  • UI-Grid only totals on expanded groups (this isn't very clear). Currently filtering collapses rows when the inline filter is removed.

Features

  • There is no way to know which server side filters have been applied from the client module. This could become very unclear after a number of filters have been applied. The module could use the standard bhima filter component/ utility bar.
@sfount sfount added the review label Nov 2, 2016
jniles pushed a commit to jniles/bhima that referenced this issue Nov 10, 2016
feat(journal): implement advanced filtering
477f0e6 
This commit implements advanced filtering on the Posting Journal through
a modal form.  The module uses bhFiltersApplied to display the filters
currently applied to the posting journal at the top of the dash.

Filters are cached so that they survive page reloads.  All filtering is
done using the journal API from the server.

See IMA-WorldHealth#840.  Closes IMA-WorldHealth#793.
jniles pushed a commit to jniles/bhima that referenced this issue Nov 10, 2016
feat(journal): implement advanced filtering
9b864ea 
This commit implements advanced filtering on the Posting Journal through
a modal form.  The module uses bhFiltersApplied to display the filters
currently applied to the posting journal at the top of the dash.

Filters are cached so that they survive page reloads.  All filtering is
done using the journal API from the server.

See IMA-WorldHealth#840.  Closes IMA-WorldHealth#793.
jniles pushed a commit to jniles/bhima that referenced this issue Nov 11, 2016
feat(journal): implement advanced filtering
dd6f324 
This commit implements advanced filtering on the Posting Journal through
a modal form.  The module uses bhFiltersApplied to display the filters
currently applied to the posting journal at the top of the dash.

Filters are cached so that they survive page reloads.  All filtering is
done using the journal API from the server.

See IMA-WorldHealth#840.  Closes IMA-WorldHealth#793.
jniles pushed a commit to jniles/bhima that referenced this issue Nov 11, 2016
feat(journal): implement advanced filtering
20d8c38 
This commit implements advanced filtering on the Posting Journal through
a modal form.  The module uses bhFiltersApplied to display the filters
currently applied to the posting journal at the top of the dash.

Filters are cached so that they survive page reloads.  All filtering is
done using the journal API from the server.

See IMA-WorldHealth#840.  Closes IMA-WorldHealth#793.
jniles pushed a commit to jniles/bhima that referenced this issue Nov 14, 2016
feat(journal): implement advanced filtering
c62ca80 
This commit implements advanced filtering on the Posting Journal through
a modal form.  The module uses bhFiltersApplied to display the filters
currently applied to the posting journal at the top of the dash.

Filters are cached so that they survive page reloads.  All filtering is
done using the journal API from the server.

See IMA-WorldHealth#840.  Closes IMA-WorldHealth#793.
jniles pushed a commit to jniles/bhima that referenced this issue Nov 14, 2016
feat(journal): implement advanced filtering
3b77cd7 
This commit implements advanced filtering on the Posting Journal through
a modal form.  The module uses bhFiltersApplied to display the filters
currently applied to the posting journal at the top of the dash.

Filters are cached so that they survive page reloads.  All filtering is
done using the journal API from the server.

See IMA-WorldHealth#840.  Closes IMA-WorldHealth#793.
jniles pushed a commit to jniles/bhima that referenced this issue Nov 14, 2016
feat(journal): implement advanced filtering
3436b7c 
This commit implements advanced filtering on the Posting Journal through
a modal form.  The module uses bhFiltersApplied to display the filters
currently applied to the posting journal at the top of the dash.

Filters are cached so that they survive page reloads.  All filtering is
done using the journal API from the server.

See IMA-WorldHealth#840.  Closes IMA-WorldHealth#793.
sfount pushed a commit that referenced this issue Nov 15, 2016
@sfount
feat(journal): implement advanced filtering
3372432 
This commit implements advanced filtering on the Posting Journal through
a modal form.  The module uses bhFiltersApplied to display the filters
currently applied to the posting journal at the top of the dash.

Filters are cached so that they survive page reloads.  All filtering is
done using the journal API from the server.

See #840.  Closes #793.
@jniles
Copy link
Collaborator

jniles commented May 9, 2017

I think saveState will help address the first issues of groups collapsing. That feature is described in #1050 and referenced in #1473.

@jniles jniles closed this as completed May 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jniles @sfount