refactor(journal): cancel Trial Balance from all screens #1540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Trial Balance would only let you cancel from the "Main" screen - the error screen forced you to reload the data for the "main" screen before being able to dismiss the modal. This corrects that misfeature.
jniles
force-pushed
the
refactor-trial-balance-cancel-button
branch
from
f6ad6db
to
9cc99eb
Compare
|
I'm not sure why this PR doesn't show any collisions; from what I can tell these changes where also made in a recently merged PR - #1546. I might be missing something! |
|
@sfount: 🔑 Insufficient privileges: Not in reviewers |
1 similar comment
|
@sfount: 🔑 Insufficient privileges: Not in reviewers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Trial Balance would only let you cancel from the "Main" screen - the error screen forced you to
reload the data for the "main" screen before being able to dismiss the modal. This corrects that
misfeature.
Thank you for contributing!
Before submitting this pull request, please verify that you have:
For a more detailed checklist, see the official review checklist that this PR will be evaluated against.
Ensuring that the above checkboxes are completed will help speed the review process and help build a stronger application. Thanks!