Journal transaction ID sorting bug, issue #992 #1610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
troyev
changed the title
troyev
changed the title
jniles
approved these changes
May 8, 2017
| @@ -83,10 +59,11 @@ function GridSortingService(util) { | |||
| // global sorting configuration | |||
| gridOptions.enableSorting = true; | |||
|
|
|||
| this.transactionIds = transactionIds; | |||
| var nullValuesResult = this.gridApi.core.sortHandleNulls(a, b); | ||
| // determine integer (reference) value by extracting it from the transaction ID | ||
| // match returns an array of mathces - take the first element | ||
| first = Number(/[a-z,A-Z]*([0-9]*)/g.exec(a)[1]); |
There was a problem hiding this comment.
The comments are highly appreciated!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears there were two main issues: one being that the sorting functions were not exposed correctly, so Undefined was passed to grid-ui, and two being that the sorting function didn't seem to be correct for strings like "HEV142 (2)".
Let me know your thoughts on the changes and if they work for you.