fix(reports): keep url/report data in sync #4142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a longstanding bug in the reports module in which the report's reference would get out of sync with the URL. When a user attempted to save the report or view the archives, sometimes a different report title would be presented. We re-sync the report data on every transition now, since the resolve() was not being called when :reportKey was changing in the URL.
jniles
force-pushed
the
fix-report-url-bugs
branch
from
dcc4076
to
77d9039
Compare
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Feb 3, 2020
4142: fix(reports): keep url/report data in sync r=jniles a=jniles This PR fixes a longstanding bug in the reports module in which the report's reference would get out of sync with the URL. When a user attempted to save the report or view the archives, sometimes a different report title would be presented. We re-sync the report data on every transition now, since the `resolve()` was not being called when :reportKey was changing in the URL. **Demonstration of the problem**  **Demonstration of the solution**  Co-authored-by: Jonathan Niles <jonathanwniles@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a longstanding bug in the reports module in which the
report's reference would get out of sync with the URL. When a user
attempted to save the report or view the archives, sometimes a different
report title would be presented. We re-sync the report data on every
transition now, since the
resolve()was not being called when :reportKeywas changing in the URL.
Demonstration of the problem
Demonstration of the solution
