feat(reports): add file type detection #4143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will need to be merged after #4142 to keep things clean. |
Adds file type detection to the reports archive page so that we are not proposing to the user to print reports that are not printable (xlsx for example). It also adds features to provide the correct font awesome icon depending on the extension to help a user determine which kind of file they will be downloading.
Adds unit tests to the parser functions in the BaseReports file.
jniles
force-pushed
the
chore-add-file-type-to-report-archives
branch
from
e87c62e
to
7a99978
Compare
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Feb 3, 2020
4143: feat(reports): add file type detection r=jniles a=jniles Adds file type detection to the reports archive page so that we are not proposing to the user to print reports that are not printable (xlsx for example). It also adds features to provide the correct font awesome icon depending on the extension to help a user determine which kind of file they will be downloading. **Example**  4149: fix(inventory): allow deletion from inventory r=jniles a=jniles This commit removes the foreign key constraints from the inventory_log to allow deletion from the inventory. It also fixes the http headers sent twice error in the error handler. Closes #4147. Co-authored-by: Jonathan Niles <jonathanwniles@gmail.com>
|
This PR was included in a batch that was canceled, it will be automatically retried |
|
bors r- |
Canceled |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Feb 3, 2020
4143: feat(reports): add file type detection r=jniles a=jniles Adds file type detection to the reports archive page so that we are not proposing to the user to print reports that are not printable (xlsx for example). It also adds features to provide the correct font awesome icon depending on the extension to help a user determine which kind of file they will be downloading. **Example**  4149: fix(inventory): allow deletion from inventory r=jniles a=jniles This commit removes the foreign key constraints from the inventory_log to allow deletion from the inventory. It also fixes the http headers sent twice error in the error handler. Closes #4147. Co-authored-by: Jonathan Niles <jonathanwniles@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds file type detection to the reports archive page so that we are not
proposing to the user to print reports that are not printable (xlsx for
example). It also adds features to provide the correct font awesome
icon depending on the extension to help a user determine which kind of
file they will be downloading.
Example
