fix(cost centers): filter on reference type #5956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes the cost center functions to ensure that we are filtering the account references by the cost center id.
jniles
force-pushed
the
fix-filter-account_reference-on-is-cost-center
branch
from
9e35722
to
e0f918c
Compare
During invoicing, we now assign the "principal" cost centers independently.
|
@lomamech can I get a review? |
mbayopanda
approved these changes
Oct 4, 2021
| SELECT account_reference_id FROM account_reference_item JOIN account_reference | ||
| ON account_reference_item.account_reference_id = account_reference.id | ||
| WHERE account_reference_item.account_id = account_id | ||
| and account_reference.reference_type_id = 1 -- reference_type_id 1 is cost center |
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes the cost center functions to ensure that we are filtering the account references by the cost center id. I've also combined both of the functions for calculating cost centers into a single file.