Modified the rumer integration test to work in different time zones #7390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seem like a reasonable temporary solution to me. LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I run the integration tests in Pacific time (UTC - 8 hours), the RUMER integration test fails. I tracked this down to the way that the Javascript
Date()function treats inputs. If the input is only a date, it interprets it as UTC, but if it includes a time, it treats it as local time. (See https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Date#date_time_string_format). I was able to work around the problem with the test by adding a time component to the date strings in the test.This is apparently the same issue pointed out by @sfount in Issue #1793. Also by @mbayopanda in Issue #3157.
See also Issue #7385.
If this passes the github CI/semaphore tests, I think this modification will not present problems for running tests in DR Congo.
@jniles, please run the integration tests in your time zone.
Note: This PR only impacts tests, so should not prevent moving ahead on a release.