fix(checkins): fix patient checkin report #795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jniles
force-pushed
the
fix-patient-checkin-report
branch
from
139491f
to
ae2b500
Compare
|
@mbayopanda, can I get a review? |
This commit updates the patient checkin report to the latest report standard. It adds integration tests for the patient checkin report route. Closes IMA-WorldHealth#770.
jniles
force-pushed
the
fix-patient-checkin-report
branch
from
ae2b500
to
cfda425
Compare
mbayopanda
reviewed
Oct 13, 2016
There was a problem hiding this comment.
👍 All things in this PR are good, it just notice that the pdf report of checkin it is not translated.
Other thing is, the french transalation of checkin (verification) it is not well for the context, i think we have to choose a good name for example Visite and Signaler visite du patient for text on the checkin button.
| * @requires renderers/pdf | ||
| * @requires lib/db | ||
| * @requires lib/ReportManager | ||
| * @requires Patients |
There was a problem hiding this comment.
Could we have a good name for checkin in the french transaction
Verification des patients is not very clear for the action to do.
|
I've created an issue to track the updates suggested by @mbayopanda #811. I suggest that this pull request is merged with translations to follow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the patient checkin report to the latest report standard. It adds integration tests for the patient checkin report route.
Closes #770.
Thank you for contributing!
Before submitting this pull request, please verify that you have:
For a more detailed checklist, see the official review checklist that this PR will be evaluated against.
Ensuring that the above checkboxes are completed will help speed the review process and help build a stronger application. Thanks!