I-ALiRT - Test decom for HIT CCSDS

[laspsandoval]

Change Summary

Overview

Test decom for HIT CCSDS

New Files

imap_processing/ialirt/packet_definitions/ialirt_hit.xml

• packet definitions for hit packet that is generated onboard the spacecraft

imap_processing/ialirt/l0/decom_ialirt.py

• name change for time_keys based on new packet definitions

imap_processing/ialirt/packet_definitions/ialirt.xml

• update to packet definitions

Testing

imap_processing/tests/ialirt/unit/test_decom_ialirt_hit.py

• Verification that test data was properly parsed.

Test data:
hit_ialirt_sample.ccsds
hit_ialirt_sample.csv
hit_ialirt_sample_header.csv

[laspsandoval]

I think that the next step for this is to populate HIT test data into the I-ALiRT SC packet. That way I can use it for testing architecture. Please comment on this idea.

[greglucas]

This is an interesting case because we won't ever get these packets, these are only for the spacecraft.

You currently have all of your decoding logic in the tests, you should move the calculations into the actual code and then only call the functions within the test.

Can you switch over to using the packet_file_to_datasets() helper function here as well?

[greglucas]

I think that the next step for this is to populate HIT test data into the I-ALiRT SC packet. That way I can use it for testing architecture. Please comment on this idea.

This seems like it is a good idea, but could also be complicated because you're having to inject specific bytes into another specific bytes object. If it is easy, it is likely worth doing, but I wouldn't spend too much time on it either.

More important in my opinion is writing a generic function that can grab the proper HIT values you need.

def process_hit(xarray_dataset):
    # do something with ds["HIT_EVENT_DATA_00"], ...
    # This should be agnostic of whether you are passing in only the HIT CCSDS decoded dataset or the I-ALiRT decoded dataset.

[vmartinez-cu]

Looks good to me!