Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GET /types endpoint missing access control #234

Closed
longshuicy opened this issue Oct 12, 2023 · 1 comment · Fixed by #237
Closed

GET /types endpoint missing access control #234

longshuicy opened this issue Oct 12, 2023 · 1 comment · Fixed by #237
Assignees
@navarroc
Labels
1storypoint Less than two hours of work, requiring only email communication bug Something isn't working
Milestone
1.22.0

Comments

@longshuicy
Copy link
Member

https://github.com/IN-CORE/incore-services/blob/develop/server/semantics-service/src/main/java/edu/illinois/ncsa/incore/service/semantics/controllers/TypeController.java#L96

here we are missing the check for

Set<String> userMembersSet = authorizer.getAllMembersUserHasReadAccessTo(username, spaceRepository.getAllSpaces(), groups);
@longshuicy longshuicy added bug Something isn't working 1storypoint Less than two hours of work, requiring only email communication labels Oct 12, 2023
@longshuicy
Copy link
Member Author

We might also double check all the other endpoints

@navarroc navarroc added this to the 1.22.0 milestone Oct 17, 2023
@navarroc navarroc self-assigned this Oct 18, 2023
navarroc added a commit that referenced this issue Oct 18, 2023
@navarroc
Fixes #234 Semantic services types endpoint missing access control
e517a14
@navarroc navarroc linked a pull request Oct 18, 2023 that will close this issue
Fixes #234 Semantic services types endpoint missing access control #237
Merged
longshuicy pushed a commit that referenced this issue Oct 20, 2023
@navarroc
Fixes #234 Semantic services types endpoint missing access control (#237
999b0a1 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@navarroc navarroc

Labels
1storypoint Less than two hours of work, requiring only email communication bug Something isn't working
Projects
None yet
Milestone
1.22.0
Development

Successfully merging a pull request may close this issue.

Fixes #234 Semantic services types endpoint missing access control IN-CORE/incore-services
2 participants
@navarroc @longshuicy