Move to Java 11. #492
Merged
Move to Java 11. #492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmungall
approved these changes
Nov 3, 2021
|
I’ll build and run the test suite on my M1 (arm64) machine tomorrow. I don’t expect any issue but just in case… |
|
All tests passed successfully on arm64. :) |
|
I will run some additional tests over the weekend, but an important test case is the fbbt prepare release process due to the custom Java jars in there. @gouttegd can you run a full release with the Java 11 images of fbbt, just to be sure all components still work? |
|
@matentzn Done, no issues. :) |
|
Never mind! blazegraph-runner is not in any of these images; just confusion on my part. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I propose we move to Java 11. It's been out as the LTS version for 3 years. Some libraries are starting to drop compatibility with Java 8 (e.g., Jena 4.x). In my experience Java 11 has better performance as well. Making the change here doesn't force any particular tool (like ROBOT) to drop support for Java 8.