Build rdftab from source. #593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As rdftab is not available as a pre-built binary for arm64 (yet?), we install it from source.
matentzn
reviewed
May 4, 2022
docker/builder/Dockerfile
Outdated
| @@ -118,6 +118,16 @@ RUN wget -nv https://github.com/fastobo/fastobo-validator/archive/refs/tags/v0.4 | |||
| cd /build && \ | |||
| rm -rf fastobo-validator-0.4.0 fastobo-validator-0.4.0.tar.gz /root/.cargo | |||
|
|
|||
| # Compile rdftab. | |||
| RUN wget -nv https://github.com/ontodev/rdftab.rs/archive/refs/tags/v0.1.1.tar.gz \ | |||
There was a problem hiding this comment.
Can we extract the version here as we usually do? Just to make updating to later versions easier.
There was a problem hiding this comment.
From my experience it’s not that useful when building from source, as updating to a later version most often requires some work anyway beyond merely changing the version number. But sure.
There was a problem hiding this comment.
Usually I agree, but because of the git diff not showing lines around, it is very hard to review a pull request "bumped version number of X" - you always then have to "view file" if you want to be sure they bumped it in all places..
matentzn
approved these changes
May 4, 2022
|
Thank you @gouttegd looks great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR amends #590 to install
rdftabby compiling it from source, as no pre-builtrdftabbinary for arm64 is available (yet?).