Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build rdftab from source. #593

Merged
merged 2 commits into from
May 4, 2022
Merged

Build rdftab from source. #593

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7e44187
Build rdftab from source.
gouttegd May 3, 2022
7b8551a
Parameterize the version of rdftab.
gouttegd May 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,8 +108,3 @@ RUN wget -nv https://github.com/balhoff/relation-graph/releases/download/v$RG/re
&& tar -zxvf relation-graph-$RG.tgz \
&& mv relation-graph-$RG /tools/relation-graph \
&& chmod +x /tools/relation-graph

# rdftab
ENV RDFTAB=0.1.1
RUN wget -nv https://github.com/ontodev/rdftab.rs/releases/download/v$(RSDTAB)/rdftab-x86_64-unknown-linux-musl -O /tools/rdftab \
&& chmod +x /tools/rdftab
10 changes: 10 additions & 0 deletions docker/builder/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,16 @@ RUN wget -nv https://github.com/fastobo/fastobo-validator/archive/refs/tags/v0.4
cd /build && \
rm -rf fastobo-validator-0.4.0 fastobo-validator-0.4.0.tar.gz /root/.cargo

# Compile rdftab.
RUN wget -nv https://github.com/ontodev/rdftab.rs/archive/refs/tags/v0.1.1.tar.gz \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we extract the version here as we usually do? Just to make updating to later versions easier.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$RDFTAB_VERSION

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my experience it’s not that useful when building from source, as updating to a later version most often requires some work anyway beyond merely changing the version number. But sure.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usually I agree, but because of the git diff not showing lines around, it is very hard to review a pull request "bumped version number of X" - you always then have to "view file" if you want to be sure they bumped it in all places..

-O /build/rdftab-0.1.1.tar.gz && \
tar xf rdftab-0.1.1.tar.gz && \
cd rdftab.rs-0.1.1 && \
cargo build --release && \
install -D -m 755 target/release/rdftab /staging/full/usr/bin/rdftab && \
cd /build && \
rm -rf rdftab.rs-0.1.1 rdftab-0.1.1.tar.gz /root/.cargo

# Compile Konclude if we are not on x86_64
# (building Konclude is time-consuming, so we avoid it
# on x86_64 where a pre-compiled binary is available).
Expand Down