proposed commits to make addAttribute() have a prefix parameter #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ibute to specify a prefix. For any "type" attributes, they are now qualified with the "prov" prefix. Any other explicitly named attributes are given the "ni" prefix. That leaves attributes whose names are data-driven (like environment variables), and for now these get a NULL prefix. addAttribute() allows prefix to be NULL, but W3C PROV may require that attributes have a namespace prefix so this may need to be revisited.
|
hi syam, thanks for fixing these namespace issues. hopefully we will have everything in a namespace we can refer to soon. we had a good discussion today and probably will have a briefing at the next derived_data meeting. |
satra
added a commit
that referenced
this pull request
Jan 19, 2012
proposed commits to make addAttribute() have a prefix parameter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a prefix parameter to addAttribute(). Change all calls to addAttribute to specify a prefix. For any "type" attributes, they are now qualified with the "prov" prefix. Any other explicitly named attributes are given the "ni" prefix. That leaves attributes whose names are data-driven (like environment variables), and for now these get a NULL prefix. addAttribute() allows prefix to be NULL, but W3C PROV may require that attributes have a namespace prefix so this may need to be revisited.