1126 break up largo byline #1251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rtions of the largo byline function out into separate functions
…go_seo, for topical reasons
…wn components, for much the same reason as largo_byline was
…of errors. Somehow, the array() passed in largo_byline() to the largo_byline action is being outright replaced by a string, a string that is the output of largo_byline_coauthors() or so it appears. Here's the logged argument, and where it was throwing the error. [11-Jul-2016 18:25:05 UTC] '<span class="by-author"><span class="by">By</span> <span class="author vcard" itemprop="author"></span></span>' [11-Jul-2016 18:25:05 UTC] PHP Warning: extract() expects parameter 1 to be array, string given in /vagrant/wp-content/themes/largo-dev/inc/post-tags.php on line 165 [11-Jul-2016 18:25:05 UTC] '<span class="by-author"><span class="by">By</span> <span class="author vcard" itemprop="author"></span></span>' [11-Jul-2016 18:25:05 UTC] PHP Warning: extract() expects parameter 1 to be array, string given in /vagrant/wp-content/themes/largo-dev/inc/post-tags.php on line 165
…, thanks to Jake Spurlock
…his function does not exist
This reverts commit 8400768.
… it is" This reverts commit a30deda.
This reverts commit 004d339.
…t to largo_seo, for topical reasons" This reverts commit f5bb75b.
….php" This reverts commit 101bb1a.
…media.php" This reverts commit 792a9ad.
This reverts commit 10b3b4d.
… for Co-Authors Plus guest users
…go_get_user_avatar_id
|
This is ready for review; the failing tests appear to be the usual batch of PHP 5.5 type-safety and WordPress 4.4+ taxonomy term changes. |
| * If job titles are enabled by Largo's theme option, display the one for this author | ||
| */ | ||
| function job_title() { | ||
| $show_job_titles = of_get_option( 'show_job_titles' ); |
There was a problem hiding this comment.
of_get_option should always have a default value set
|
@benlk just those couple small things, but otherwise this lgtm. nice work on this. huge improvement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Largo_Bylineto create a byline, in the new fileinc/byline_class.php32x32image'edit_published_posts'capability, where before it was merely'edit_posts'capability. The distinction is that if a user cannot edit a published post, now they will not see the link.largo_byline()to a wrapper around$byline = new Largo_Byline( $options );Largo_Bylineto support coauthors withLargo_CoAuthors_BylineLargo_Bylineto support Largo custom bylines withLargo_Custom_BylineLargo_Custom_Bylineis fully separate fromLargo_Bylineto make deprecating it easier when we implement Deprecate Largo's custom byline feature #1249.Largo_Custom_BylineandLargo_CoAuthors_Bylineoutput tolargo_byline()when situationally appropriate.largo_byline()will awaysreturnthe byline's HTML now, where before it only returned if it wasn'techoing the bylineline-height.largo_get_avatar_srcthat was trying to use email addresses as user IDsWhy
Continuing on #1248 for #1126, this is the cleanup of that PR with requested changes. This replaces the action created in that PR with a series of classes, each only applied at the correct time.
Questions for review
@sincetag?