-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
63: filter data, rearrange plugin includes #81
Conversation
This is probably not going to make it into 0.3 because of time constraints, but there's room for it in a follow-up release. |
refactoring in progress, but the network code is not being output! |
|
Testing complete locally; lazy-loaded and non- alike render. Testing complete on a staging site using DFW to serve ads:
|
This PR is a WIP. 🚨
Changes
Housekeeping:
Implementation of #63 (comment) to allow filtering of options used by
jquery.dfp.js
:$data
before it's localised by callingapply_filters( 'dfw_js_data', $data )
on itjquery.dfw.js
to load arbitrary options from thedfw
option, same as the footer script.$data
to be the appropriate keys for use as the configuration options thatjQuery.dfp
is looking for. But this might break other uses ofnetwork_code
, and we should keep that in thedfw
JSON object for legacy support.Why
For #63 and GDPR compliance
Testing/Questions
Questions that need to be answered before merging:
Steps to test this PR: