Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In search results, apply overflow-wrap: break-word; to URLs #1509

Closed
2 tasks
benlk opened this issue Aug 7, 2018 · 1 comment
Closed
2 tasks

In search results, apply overflow-wrap: break-word; to URLs #1509

benlk opened this issue Aug 7, 2018 · 1 comment
Assignees
Labels
priority: normal Must be completed before release of this version of plugin. status: needs review
Milestone

Comments

@benlk
Copy link
Collaborator

benlk commented Aug 7, 2018

screen shot 2018-08-07 at 5 19 19 pm

Given a URL whose length between the first character and the first hyphen is longer than the text column is wide, we need to make sure that wraps at the end of the column rather than overflowing.

https://github.com/INN/largo/blob/62127383aae0e070883c4f915016582d14191535/partials/content-search.php#L20-L24

  • adding overflow-wrap: break-word; to the a tag will do it, but it needs to be scoped to the search result markup in partials/content-search.php.
  • If the URL is always going to be longer than the date, could we also get rid of the .sep separator and just have the date and URL be on separate lines?
@benlk benlk added priority: normal Must be completed before release of this version of plugin. status: needs review labels Aug 7, 2018
@benlk benlk added this to the 0.6 - Performance & SEO milestone Aug 7, 2018
@benlk benlk modified the milestones: 0.6.1 - Bugfixes, 0.6.2 Dec 7, 2018
@benlk benlk modified the milestones: 0.6.2, 0.6.3 Dec 20, 2018
@joshdarby joshdarby assigned joshdarby and unassigned tylermachado May 14, 2019
@joshdarby
Copy link
Collaborator

@benlk This is ready for review in #1710.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: normal Must be completed before release of this version of plugin. status: needs review
Projects
None yet
Development

No branches or pull requests

3 participants