Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should largo_byline require an explicit post to be specified? #1517

Open
3 of 6 tasks
benlk opened this issue Aug 17, 2018 · 3 comments
Open
3 of 6 tasks

Should largo_byline require an explicit post to be specified? #1517

benlk opened this issue Aug 17, 2018 · 3 comments
Labels
category: clean up unused code/clean up items Estimate: < 2 Hours good for beginners hacktoberfest help wanted priority: normal Must be completed before release of this version of plugin. type: feature request
Projects
Largo 0.7
Milestone
0.7 - Foundation ...

Comments

@benlk
Copy link
Collaborator

benlk commented Aug 17, 2018 •
edited
Loading

This would need to be undertaken in steps:

  • in one release of Largo: 0.6
    • add warning output on WP_DEBUG|LARGO_DEBUG that notifies devs that largo_byline is being called without an express post ID or post object
    • note intent to deprecate and provide docs on how to call it with a post ID or WP_Post object
  • in the subsequent release: 0.7
    • output the error message in the actual byline.
    • notes for changelog

This would lessen the chance that we have bylines that don't match stories when building custom partials.
@benlk benlk added this to the 0.6 - Performance & SEO milestone Sep 12, 2018
benlk added a commit that referenced this issue Nov 8, 2018
@benlk
Add warning output if WP_DEBUG || LARGO_DEBUG about the third paramet…
7d8aa3c 
…er of largo_byline being required

Also, fix a number of partials and templates that were not in compliance with the new regime.

Part of #1517
@benlk benlk mentioned this issue Nov 8, 2018
Merged
@benlk
Copy link
Collaborator Author

benlk commented Nov 8, 2018

#1561 merged in 0.6, so the next stage of deprecation can be in 0.7.

@benlk benlk added this to To do in Largo 0.7 via automation Aug 22, 2019
@benlk benlk added category: clean up unused code/clean up items Estimate: < 2 Hours labels Aug 22, 2019
@benlk
Copy link
Collaborator Author

benlk commented Aug 22, 2019

Deprecate largo_byline without post specified

@benlk benlk added the priority: normal Must be completed before release of this version of plugin. label Oct 7, 2019
@benlk
Copy link
Collaborator Author

benlk commented Oct 7, 2019

Adding the error message to the actual byline should be done in the else section of this chunk of code:

https://github.com/INN/largo/blob/f50df16e9e06fb9402802e2f1ce76ce058d26d76/inc/post-tags.php#L127-L138

@benlk benlk mentioned this issue Nov 14, 2019
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
category: clean up unused code/clean up items Estimate: < 2 Hours good for beginners hacktoberfest help wanted priority: normal Must be completed before release of this version of plugin. type: feature request
Projects
Largo 0.7
  
To do
Milestone
0.7 - Foundation for Customization
Development

No branches or pull requests
1 participant
@benlk