Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning output if WP_DEBUG || LARGO_DEBUG about the third parameter of largo_byline being required #1561

Merged
merged 3 commits into from
Nov 8, 2018

Conversation

benlk
Copy link
Collaborator

@benlk benlk commented Nov 8, 2018

Changes

  • Using WordPress' private function _doing_it_wrong, complain if largo_byline() is called without specifying a post or post ID.
  • fix a number of partials and templates that were not in compliance with the new regime.
  • provides changelog update and advice

Why

Because when you call largo_byline() without a post specified, sometimes the global $post and the post you're displaying stuff for don't match. This causes problems.

The first part of #1517: the plan to eventually deprecate calling largo_byline without specifiying a post.

…byline() is called without specifying a post or post ID.
…er of largo_byline being required

Also, fix a number of partials and templates that were not in compliance with the new regime.

Part of #1517
@benlk benlk merged commit 480f5f8 into 0.5-dev Nov 8, 2018
@benlk benlk deleted the 1517-largo_byline-require-post branch November 10, 2018 02:20
@benlk
Copy link
Collaborator Author

benlk commented Nov 16, 2018

Bugfixes in #1574

@benlk benlk mentioned this pull request Jul 26, 2019
27 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant