Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gutenberg: make sure Largo frontend post-content-specific classes are loaded in editor #1533

Closed
2 tasks done
benlk opened this issue Sep 11, 2018 · 1 comment
Closed
2 tasks done

Comments

@benlk
Copy link
Collaborator

benlk commented Sep 11, 2018

  • recheck that all post-content styles are included the editor-styles CSS file's includes
  • maybe break post-content styles out into a separate stylesheet that can be included on posts/pages and as an editor stylesheet? no; post-content styles affect excerpts and custom post types; we'd need to enqueue this sheet on all is_single() (doable) and on the homepages and on indexes and on places with widgets: all places where we already enqueue style.css. Also, editor-style.less already pulls in the posts-and-pages less: https://github.com/INN/largo/blob/0.5/less/editor-style.less
@benlk benlk added this to the 0.6 - Performance & SEO milestone Sep 11, 2018
@benlk
Copy link
Collaborator Author

benlk commented Sep 11, 2018

For one dev's process of doing this, see https://wptavern.com/hemingway-theme-adds-gutenberg-support.

We should think about a post-merge blog post talking about the changes we made, a sort of cleaned-up oral history version of the changelog.

@benlk benlk mentioned this issue Oct 31, 2018
14 tasks
@benlk benlk closed this as completed Nov 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant