Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Largo Image Widget doesn't display widget title #1717

Closed
benlk opened this issue Jun 3, 2019 · 2 comments
Closed

Largo Image Widget doesn't display widget title #1717

benlk opened this issue Jun 3, 2019 · 2 comments
Assignees
@joshdarby
Labels
Estimate: < 2 Hours priority: normal Must be completed before release of this version of plugin. type: bug type: feature request
Milestone
0.6.4

Comments

@benlk
Copy link
Collaborator

benlk commented Jun 3, 2019

We set the title to $instance['title'] but check for the existence of $title when determining whether to display the title:

https://github.com/INN/largo/blob/06cdb060774452911c3fc87eafd70908e58724ab/inc/widgets/largo-image-widget.php#L64-L84

Because $title is not defined, the title is never shown.
@benlk benlk added type: bug priority: normal Must be completed before release of this version of plugin. type: feature request labels Jun 3, 2019
@benlk benlk added this to the 0.6.4 milestone Jun 3, 2019
@benlk
Copy link
Collaborator Author

benlk commented Jun 19, 2019 •
edited by joshdarby
Loading

  • change $title to $instance['title'].
  • test that this works
  • find the extract()-removal PR and add that as a note in the changelog.

@joshdarby joshdarby self-assigned this Jul 9, 2019
@joshdarby joshdarby mentioned this issue Jul 9, 2019
Merged
1 task
This was referenced Jul 9, 2019
Open
Closed
Closed
This was referenced Jul 9, 2019
Closed
Open
@benlk
Copy link
Collaborator Author

benlk commented Jul 10, 2019

Fixed in #1736

@benlk benlk closed this as completed Jul 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joshdarby joshdarby

Labels
Estimate: < 2 Hours priority: normal Must be completed before release of this version of plugin. type: bug type: feature request
Projects
None yet
Milestone
0.6.4
Development

No branches or pull requests
2 participants
@benlk @joshdarby