Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch Largo to fix Gutenberg stylesheet misaligning paragraphs and left/right images #1731

Closed
2 tasks
benlk opened this issue Jun 21, 2019 · 4 comments
Closed
2 tasks
Assignees
Labels
category: gutenberg Relating to general Gutenberg compatibility category: styles affects lots of styles, requiring visual testing Estimate: < 2 Hours priority: low Nice-to-have in a release. type: bug type: feature request
Milestone

Comments

@benlk
Copy link
Collaborator

benlk commented Jun 21, 2019

If there isn't a fix for WordPress/gutenberg#16241 in WordPress Core or the Gutenberg plugin by the time that Largo 0.6.4 is ready, take the following actions:

This was reported by an INN member in https://secure.helpscout.net/conversation/884401410/3812/

This is Clickup task ID #166f8b

@benlk benlk added type: bug priority: low Nice-to-have in a release. type: feature request category: styles affects lots of styles, requiring visual testing category: gutenberg Relating to general Gutenberg compatibility labels Jun 21, 2019
@benlk benlk added this to the 0.6.4 milestone Jun 21, 2019
@joshdarby
Copy link
Collaborator

@benlk After todays discussion about the implementation of this, do we still want to create a new .less file and a ticket to remove it later on?

@benlk
Copy link
Collaborator Author

benlk commented Jul 10, 2019

Yes.

@joshdarby
Copy link
Collaborator

@benlk Could you help me reproduce this? I followed your instructions from WordPress/gutenberg#16241 on my local Current.org env

To reproduce
Steps to reproduce the behavior:

  1. With WordPress 5.2.2.1 and no Gutenberg plugin
  2. Add an image block aligned right that is less than the full column width.
  3. Following the image block, add a paragraph text block.
  4. See error

but I'm not seeing the issue? What am I missing?

Screen Shot 2019-07-11 at 9 46 12 AM

Screen Shot 2019-07-11 at 9 45 57 AM

Screen Shot 2019-07-11 at 9 48 38 AM

@joshdarby joshdarby self-assigned this Jul 11, 2019
@benlk
Copy link
Collaborator Author

benlk commented Jul 15, 2019

I think it's only visible if the image block is the first block in the post.

With a paragraph block before the image block, in Firefox:

Screen Shot 2019-07-14 at 21 51 42

Without a paragraph before the image block, in Firefox

Screen Shot 2019-07-14 at 21 52 16

With a paragraph block before the image block, in Chrome:

Screen Shot 2019-07-14 at 21 55 14

Without a paragraph before the image block, in Chrome:

Screen Shot 2019-07-14 at 21 55 23

I don't understand why that would be the case; there doesn't appear to be any difference in styles between the image block first in the post and the image block later in the post.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: gutenberg Relating to general Gutenberg compatibility category: styles affects lots of styles, requiring visual testing Estimate: < 2 Hours priority: low Nice-to-have in a release. type: bug type: feature request
Projects
None yet
Development

No branches or pull requests

3 participants