Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix floated image alignment #1165

Merged
merged 1 commit into from Jun 18, 2019
Merged

Fix floated image alignment #1165

merged 1 commit into from Jun 18, 2019

Conversation

tiagonoronha
Copy link
Contributor

Before:

Screenshot 2019-06-17 at 16 05 20

After:

Screenshot 2019-06-17 at 16 04 58

Notice how the image in the "before" screenshot is not aligned with the text.

To test:

  • Create a new post/page and add a few paragraphs.
  • Add an image and float it to the left/right.
  • Ensure that the image aligns with the text.

Closes #1127.

@tiagonoronha tiagonoronha added the status: needs review PR that needs review label Jun 17, 2019
@tiagonoronha tiagonoronha mentioned this pull request Jun 17, 2019
Closed
rodrigoprimo
rodrigoprimo approved these changes Jun 18, 2019
View reviewed changes
Copy link
Contributor

@rodrigoprimo rodrigoprimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rodrigoprimo rodrigoprimo added Status: Approved and removed status: needs review PR that needs review labels Jun 18, 2019
@tiagonoronha tiagonoronha merged commit cf9fb87 into master Jun 18, 2019
@tiagonoronha tiagonoronha deleted the fix/1127 branch June 18, 2019 15:34
@GlennMartin1 GlennMartin1 mentioned this pull request Jun 21, 2019
Closed
2 tasks
@benlk benlk mentioned this pull request Jun 21, 2019
Closed
2 tasks
@haszari haszari mentioned this pull request Apr 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rodrigoprimo rodrigoprimo rodrigoprimo approved these changes

Assignees
No one assigned
Labels
status: cherry picked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[2.5] changes on static, full-width homepage....
2 participants
@tiagonoronha @rodrigoprimo