-
-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HTTP -> HTTPS and link updates #1541
Conversation
@@ -155,7 +155,7 @@ function cftl_tax_landing_messages($messages) { | |||
7 => __('Landing Page saved.', 'cf-tax-landing'), | |||
8 => sprintf(__('Landing Page submitted. %s', 'cf-tax-landing'), $taxonomy_links), | |||
9 => sprintf(__('Landing Page scheduled for: <strong>%1$s</strong>.', 'cf-tax-landing'), | |||
// translators: Publish box date format, see http://php.net/date | |||
// translators: Publish box date format, see https://secure.php.net/manual/es/function.date.php |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This links to the Spanish-language PHP docs; our documentation is in English and so this should link to https://secure.php.net/manual/en/function.date.php instead.
@@ -107,8 +107,9 @@ | |||
rewind_posts(); | |||
$counter = 1; | |||
while ( have_posts() ) : the_post(); | |||
$post_type = get_post_type(); | |||
$post_type = get_post_type(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the trailing whitespace added in this line.
$partial = largo_get_partial_by_post_type( 'archive', $post_type, 'archive' ); | ||
echo $partial; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove this change; there is no need to echo the slug of the partial.
Lacking the requested changes, this PR will at some point be closed and its work cherry-picked into another branch. |
Closing in favor of #1555. |
This reverts commit 2fcd2a1. Per #1541 (comment), this fix should not be merged into Largo with the HTTP->HTTPS updates.
Hi, I have reviewed the topic and I have followed your instructions, I hope the change will be helpful. regards