HTTP -> HTTPS and link updates #1541
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benlk
requested changes
Oct 8, 2018
| @@ -155,7 +155,7 @@ function cftl_tax_landing_messages($messages) { | |||
| 7 => __('Landing Page saved.', 'cf-tax-landing'), | |||
| 8 => sprintf(__('Landing Page submitted. %s', 'cf-tax-landing'), $taxonomy_links), | |||
| 9 => sprintf(__('Landing Page scheduled for: <strong>%1$s</strong>.', 'cf-tax-landing'), | |||
| // translators: Publish box date format, see http://php.net/date | |||
| // translators: Publish box date format, see https://secure.php.net/manual/es/function.date.php | |||
There was a problem hiding this comment.
This links to the Spanish-language PHP docs; our documentation is in English and so this should link to https://secure.php.net/manual/en/function.date.php instead.
| @@ -107,8 +107,9 @@ | |||
| rewind_posts(); | |||
| $counter = 1; | |||
| while ( have_posts() ) : the_post(); | |||
| $post_type = get_post_type(); | |||
| $post_type = get_post_type(); | |||
There was a problem hiding this comment.
Please remove the trailing whitespace added in this line.
| $partial = largo_get_partial_by_post_type( 'archive', $post_type, 'archive' ); | ||
| echo $partial; |
There was a problem hiding this comment.
Please remove this change; there is no need to echo the slug of the partial.
benlk
modified the milestones:
0.6 - Performance & SEO,
0.7 - Foundation for Customization
|
Lacking the requested changes, this PR will at some point be closed and its work cherry-picked into another branch. |
Merged
|
Closing in favor of #1555. |
benlk
added a commit
that referenced
this pull request
Nov 6, 2018
This reverts commit 2fcd2a1. Per #1541 (comment), this fix should not be merged into Largo with the HTTP->HTTPS updates.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I have reviewed the topic and I have followed your instructions, I hope the change will be helpful. regards