Mark the Prominence metabox as a backwards-compatibility metabox #1655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change: - Removes Largo's custom "Prominence" meta box seen in the post admin on Gutenberg editors by marking that as backwards-compat metabox as described in https://wordpress.org/gutenberg/handbook/designers-developers/developers/backward-compatibility/meta-box/ - Stops passing a list of Prominence terms to the function largo_prominence_meta_box, because that's not what the sixth parameter on add_meta_box is for. Resolves #1654
benlk
added
type: bug
priority: normal
|
Testing that the box displays:
Testing that checkbox values are correctly saved and presented:
|
This was referenced Apr 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change:
largo_prominence_meta_box, because that's not what the sixth parameter on add_meta_box is for.For #1654, resolves the issue with the Prominence metabox, but doesn't resolve the issue of there being two "Featured Image" metaboxes.