Merge pull request #1655 from INN/1654-post-prominence-metabox

Mark the Prominence metabox as a backwards-compatibility metabox

changelog.md

@@ -34,8 +34,9 @@ This release contains bug fixes for Largo 0.6.
 - Cleans up the search page when no query has been entered. [Pull request #1604](https://github.com/INN/largo/pull/1604) for [issue #1603](https://github.com/INN/largo/issues/1603).
 - Defines the index 'class' in `partials/widget-content.php` when using a large image. [Pull request #1606](https://github.com/INN/largo/pull/1606) for issues [#1605](https://github.com/INN/largo/issues/1605) and [#1492](https://github.com/INN/largo/issues/1492).
 - If Co-Authors Plus is active, and if a post has an `author` term, but the term has no corresponding `guest-author` post, when running `largo_byline()`, the byline will now contain an HTML comment informing why the byline is empty. If the `WP_DEBUG` or `LARGO_DEBUG` constants are true, Largo will add a message to the server's error log of the form "post 123 should have at least one co-author, but has none!" [Pull request #1607](https://github.com/INN/largo/pull/1607) for [Automattic/Co-Authors-Plus#637](https://github.com/Automattic/Co-Authors-Plus/issues/637) and as part of the general cleanup ticket [#1492](https://github.com/INN/largo/issues/1492).
-- Further cleans up undefined variables.
 - Fix for posts with "Featured in category" selected not displaying on category RSS feeds. [Pull request #1668](https://github.com/INN/largo/pull/1668) for [issue #1598](https://github.com/INN/largo/issues/1598).
+- Fixes issue where prominence terms were not saving with the Block Editor, because the "Post Prominence" metabox was output twice. [Pull request #1655](https://github.com/INN/largo/pull/1655) for [issue #1654](https://github.com/INN/largo/issues/1654).
+- Further cleans up undefined variables.
 
 ### Upgrade notices
 

inc/post-metaboxes.php

@@ -109,7 +109,7 @@ function largo_change_default_hidden_metaboxes( $hidden, $screen ) {
 /**
  * Add our prominence taxonomy meta box with custom behavior.
  *
- * @param array $largoProminenceTerms list of prominence terms
+ * @param array $largoProminenceTerms An array of arrays describing the taxonomy terms
  * @see largo_custom_taxonomies
  */
 function largo_add_custom_prominence_meta_box($largoProminenceTerms) {
@@ -121,7 +121,9 @@ function largo_add_custom_prominence_meta_box($largoProminenceTerms) {
 			'post',
 			'side',
 			'default',
-			$largoProminenceTerms
+			array(
+				'__back_compat_meta_box' => true, // because this taxonomy metabox is covered by Gutenberg
+			)
 		);
 	}, 10);
 }