Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ReferenceError in navigation.js #1715

Merged
merged 2 commits into from
Jun 12, 2019
Merged

Fix ReferenceError in navigation.js #1715

merged 2 commits into from
Jun 12, 2019

Conversation

benlk
Copy link
Collaborator

@benlk benlk commented May 23, 2019 •
edited
Loading

Changes

@benlk benlk added type: bug priority: normal Must be completed before release of this version of plugin. Estimate: < 2 Hours labels May 23, 2019
@benlk benlk added this to the 0.6.4 milestone May 23, 2019
@benlk benlk requested a review from joshdarby May 23, 2019 23:04
@benlk
Copy link
Collaborator Author

benlk commented Jun 6, 2019 •
edited
Loading

  • needs changelog update

@benlk
Copy link
Collaborator Author

benlk commented Jun 12, 2019

I'm unable to actually reproduce the error reported in #1714; I should have better captured the brower/OS/emulation settings required. But this change doesn't trigger any new problems, and does appear to be better in the abstract.

@benlk benlk merged commit 1eb4bac into 0.5-dev Jun 12, 2019
@benlk benlk deleted the 1714-hasevent branch June 12, 2019 20:31
@benlk benlk mentioned this pull request Oct 10, 2019
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshdarby joshdarby Awaiting requested review from joshdarby

Assignees
No one assigned
Labels
Estimate: < 2 Hours priority: normal Must be completed before release of this version of plugin. type: bug
Projects
None yet
Milestone
0.6.4
Development

Successfully merging this pull request may close these issues.

ReferenceError: Can't find variable: hasEvent
1 participant
@benlk