Update Grunt, remove unnecessary items from Gruntfile, register task 'default' #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yep, I'm seeing that with #33 checked out as well. Will put a patch in this PR. |
|
@benlk Do you want help narrowing down what happened or do you have an idea? |
|
Assistance would be welcome. |
|
It's not WPBuddy/largo#1715 |
|
@joshdarby does this go away for you if in Appearance > CSS Variables you hit "Save Variables"? |
|
@benlk Sure does. |
|
Then it sounds like both of us had pre-Largo-0.6.4 CSS compiled, but since that isn't updated automatically when Largo updates (we require a human to push the button) we had to clear the old styles and generate new ones. It's not a problem with this PR or #33, or even this theme. (And WPBuddy/largo#1137 would solve the problem by getting rid of that cached stylesheet.) OK to merge? |
|
Awesome. 👍 |
joshdarby
approved these changes
Oct 10, 2019
CITY-008 - Website Redesign
automation
moved this from In progress
to Reviewer approved
Oct 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This pull request makes the following changes:
package.lockversiontask, because we haven't been versioning this software for releasegrunt-contrib-pot,grunt-confirm,grunt-git,grunt-po2mo,grunt-pot, andgrunt-versionas they're unused in this project. If we end up making this theme translatable, we should usegrunt-shellas a wrapper for thewp i18ntools.Why
This should clear up the npm-related security alerts for this repo, as well as bring improved syntax handling in LESS files for CSS'
calc().Testing/Questions
Features that this PR affects:
Questions that need to be answered before merging:
Steps to test this PR:
gruntand watch for errors: there should be none, and thedefaulttask should be run.