Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if $instance['title'] is empty rather than $title for Largo Image Widget #1736

Merged
merged 1 commit into from
Jul 9, 2019

Conversation

joshdarby
Copy link
Collaborator

Changes

This pull request makes the following changes:

  • Fixes an issue where the widget title wasn't displaying in the Largo Image Widget, due to trying to use the $title variable which was removed when we stopped using extract in pull request #1565.

Why

For #1717.

Testing/Questions

Features that this PR affects:

  • Largo Image Widget

Questions that need to be answered before merging:

  • Are all other instances of title ok on other widgets?

Steps to test this PR:

  1. Add Largo Image Widget to a sidebar.
  2. Add a title to the Largo Image Widget.
  3. Verify the title displays for the widget.

@joshdarby joshdarby added priority: normal Must be completed before release of this version of plugin. Estimate: < 2 Hours labels Jul 9, 2019
@joshdarby joshdarby added this to the 0.6.4 milestone Jul 9, 2019
@joshdarby joshdarby requested a review from benlk July 9, 2019 19:20
@joshdarby joshdarby self-assigned this Jul 9, 2019
Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ A review job has been created and sent to the PullRequest network.


Check the status or cancel PullRequest code review here.

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✖️ This code review was cancelled. See Details

@benlk
Copy link
Collaborator

benlk commented Jul 9, 2019

Testing of this widget passes.

Regarding the question of the other widgets, I'll run through those quickly:

@joshdarby
Copy link
Collaborator Author

@benlk I can help with that. Just let me know which ones I can take.

@benlk
Copy link
Collaborator

benlk commented Jul 9, 2019

You start from the bottom I'll start from the top? Check off items in my comment as we go, or edit it to reference issues.

@joshdarby
Copy link
Collaborator Author

joshdarby commented Jul 9, 2019

editing this as I go:

largo-twitter.php doesn't have a title option, but rather a widget title link option, which doesn't work.

largo-series-posts.php title is taken from the name of the selected series.

largo-prev-next-post-links.php doesn't have a title option, but again has a widget title link option that doesn't work. Also throws this fun warning:

Notice: Undefined index: in_same_cat in /Users/josh/Desktop/Work/umbrella/wp-content/themes/largo-dev/inc/widgets/largo-prev-next-post-links.php on line 23

@benlk
Copy link
Collaborator

benlk commented Jul 9, 2019

prev-next-posts I'd create an issue for, if only because we've got the title link field.

Let's merge this PR and then decide if all those other issues should be tackled in 0.6.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Estimate: < 2 Hours priority: normal Must be completed before release of this version of plugin.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants