processing of annotations

[swolf91]

I found a bug with the processing of annotations.
In my project I've a class AnnotationProcess which extends the AbstractProcessor<CtAnnotation<?>>

Imagine you've the following annotations:

public @interface OuterAnnotation
{
    public MiddleAnnotation[] value();
}

public @interface MiddleAnnotation
{
    public InnerAnnotation value();
}

public @interface InnerAnnotation
{
    public String value();
}

The processing of the InnerAnnotation doesn't work if the MiddleAnnotation is used as an array. So the processor isn't invoked with the InnerAnnotation.

examples:

@OuterAnnotation(@MiddleAnnotation(@InnerAnnotation("hello")))
public void test() // The InnerAnnotation will be processed
{}

@OuterAnnotation({@MiddleAnnotation(@InnerAnnotation("hello")), @MiddleAnnotation(@InnerAnnotation("hello again"))})
public void test2() // The InnerAnnotation won't be processed
{}

[GerardPaligot]

I also tested and I confirm the bug. If you don't make a PR, I add it in my to-do list. :)

Thanks for reporting this bug.

[swolf91]

@GerardPaligot At the moment I don't work on that. So you can add it to your todo list.
If I start working on it I'll let you know or rather I'll ask for the status before.

[KonstantinSviridov]

+1
Actually, arrays of annotations are not captured at all, because CtNewArray is only allowed to contain CtExpressons while CtAnnotation does not extend it.

[petitpre]

Is it fixes by the pull request #83?

[swolf91]

@petitpre No, #83 doesn't fix this. Have a look at #82 to get a short description about the difference.

[swolf91]

@GerardPaligot Did you have a look how to fix this issue already?

[GerardPaligot]

I'm working on it today. I identified the problem but the solution is a little bit tricky. PR probably soon.

[ocean7]

Want to +1 Konstantin's comment (#60 (comment)) arrays of annotations aren't being captured at all.

[KonstantinSviridov]

Hi guys.

What is the spoon version which has this issue fixed?
It does not work for me with 3.0:

<dependency>
    <groupId>fr.inria.gforge.spoon</groupId>
    <artifactId>spoon-core</artifactId>
    <version>3.0</version>
</dependency>

[GerardPaligot]

Hi @KonstantinSviridov,

Did you test the version 3.1?

[KonstantinSviridov]

@GerardPaligot, thank you. With 3.1 it is fine.

[GerardPaligot]

It's our fault, the website isn't updated with this version. This will be fixed very soon.