Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Invalid end column #2159

Merged
merged 1 commit into from
Jul 3, 2018
Merged

fix: Invalid end column #2159

merged 1 commit into from
Jul 3, 2018

Conversation

Egor18
Copy link
Contributor

@Egor18 Egor18 commented Jul 3, 2018

Hi! I've found out that getEndColumn() from CompoundSourcePositionImpl works incorrectly.
Here are 2 screenshots to illustrate the problem.
Now:
not_ok
Expected:
ok

The problem is that only getEndLine() has been overriden, but not getEndColumn().
So this PR contains fix and additional test.

@Egor18
Copy link
Contributor Author

Egor18 commented Jul 3, 2018

Without this fix assertEquals(2, pos.getEndColumn()); fails, because pos.getEndColumn() returns 14 (wrong).

@surli
Copy link
Collaborator

surli commented Jul 3, 2018

LGTM @tdurieux ok to merge?

@tdurieux
Copy link
Collaborator

tdurieux commented Jul 3, 2018

yes

@surli surli merged commit 7aee315 into INRIA:master Jul 3, 2018
@surli surli mentioned this pull request Jul 4, 2018
Closed
@Egor18 Egor18 deleted the fixEndColumn branch October 5, 2018 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Egor18 @surli @tdurieux