WIP: perf(.travis.yml): merge travis builds to fall under 5 builds #2782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nharrand
changed the title
|
Ok, my bad
|
|
I would personnally merge mvn339-jdk8 and jkd8 to keep only one. And I'd remove jdk9 since it won't be a LTS: we should only test against JDK8 and 11, since 11 is the new LTS. For corner cases we should have checks for 7, 9 and 10 on another CI. |
|
Sounds good to me. Following your advice, I've replaced As we are still one build short, I've left the merge between |
…avis-build-reduction
…avis-build-reduction
…avis-build-reduction
…avis-build-reduction
…avis-build-reduction
nharrand
changed the title
|
LGTM |
|
Waiting for #2789 to be merged before rebasing. |
monperrus
changed the title
surli
pushed a commit
that referenced
this pull request
Dec 3, 2018
…ges (#2789) Related to adding a travis build with jdk 11 See #2782 `CtFieldWrite.getTarget()` on `array.length` used to return a `CtVariableWrite` for some reasons... But with jdk 11 now returns a `CtVariableRead`... `FieldAccessTest#testFieldAccessOnUnknownType()` has been changed to handle both... by expecting a `CtVariableAccess`. This (combined with #2787) fixes tests for jdk 11 as can be seen here ( https://travis-ci.org/INRIA/spoon/jobs/460289160 ). Wether this is satisfaying or not, is up to debate. WDYT?
|
OK, this finally works. |
surli
pushed a commit
that referenced
this pull request
Dec 10, 2018
cleaning under the carpet of #2782
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As travis builds are limited to 5 parallel builds for Spoon, I propose to merge the 3 fastest builds into one. (This 3 builds are just verification that are not tests, and are quite fast.)
Hopefully this new build is still faster than the slowest one, so it should be a net gain onboth time andresources.