review: fix: set declaring type for array field accesses #5206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SirYwell
changed the title
|
Thanks @SirYwell |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Step 1 addressing #5199.
Previously, spoon set the declaring type to the type of the field if JDT didn't provide a declaring type. From running all tests, this seems to be only the case for access to the
lengthfield of arrays. Instead of setting the declaring type tointthen, we now use the type binding provided by JDT that holds the actual declaring type.Note that this does not fully fix the bug, but we get
The field java.lang.String[]#length not foundinstead ofThe field int#length not found.