Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

review: refactor: replace direct access to ContextBuilder#stack with methods #5241

Merged
merged 2 commits into from Jun 1, 2023

Conversation

SirYwell
Copy link
Collaborator

Replaces repetitive code with methods that simplify the code. This also helps to get rid of NPE warnings.

@sonatype-lift
Copy link
Contributor

sonatype-lift bot commented May 30, 2023

🛠 Lift Auto-fix

Some of the Lift findings in this PR can be automatically fixed. You can download and apply these changes in your local project directory of your branch to review the suggestions before committing.1

# Download the patch
curl https://lift.sonatype.com/api/patch/github.com/INRIA/spoon/5241.diff -o lift-autofixes.diff

# Apply the patch with git
git apply lift-autofixes.diff

# Review the changes
git diff

Want it all in a single command? Open a terminal in your project's directory and copy and paste the following command:

curl https://lift.sonatype.com/api/patch/github.com/INRIA/spoon/5241.diff | git apply

Once you're satisfied, commit and push your changes in your project.

Footnotes

  1. You can preview the patch by opening the patch URL in the browser.

@SirYwell SirYwell marked this pull request as ready for review May 30, 2023 17:29
@SirYwell SirYwell changed the title wip: refactor: replace direct access to ContextBuilder#stack with methods review: refactor: replace direct access to ContextBuilder#stack with methods May 30, 2023
Copy link
Collaborator

@MartinWitt MartinWitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement

@MartinWitt MartinWitt merged commit 010ee5b into INRIA:master Jun 1, 2023
10 of 11 checks passed
@MartinWitt MartinWitt deleted the refactor/context-stack branch June 1, 2023 11:48
@MartinWitt
Copy link
Collaborator

Thanks @SirYwell

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants