review: fix: add handling for UnresolvedReferenceBinding in ReferenceBuilder #5294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinWitt
changed the title
MartinWitt
changed the title
|
Given the current design, the new method has to return null. Any empty |
MartinWitt
changed the title
MartinWitt
changed the title
MartinWitt
changed the title
I-Al-Istannen
requested changes
Jun 20, 2023
src/test/resources/jdk/Class.java
Outdated
There was a problem hiding this comment.
I'd be for minimizing this and recreating the bug :^)
|
I haven't found any small reproducer, so lets close this and live with the bug. |
|
I'd be in favor of deleting the test and merging it without any. The change is localized to an if that is not triggered by anything currently (or crashes), so we can't really make stuff worse. |
I-Al-Istannen
approved these changes
Jun 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am scared to add JDK code to the test resources. Any better suggestions? fixes #5290