Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

review: fix: add handling for UnresolvedReferenceBinding in ReferenceBuilder #5294

Merged
merged 5 commits into from
Jul 3, 2023
Merged

review: fix: add handling for UnresolvedReferenceBinding in ReferenceBuilder #5294

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6595450
fix: add handling for UnresolvedReferenceBinding in ReferenceBuilder
MartinWitt Jun 19, 2023
cf5239c
checkstyle
MartinWitt Jun 19, 2023
9d5cfb4
add SuppressWarnings
MartinWitt Jun 19, 2023
afbc681
up
MartinWitt Jun 30, 2023
6529484
Merge branch 'master' into leading-constrictor
MartinWitt Jun 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
22 changes: 22 additions & 0 deletions src/main/java/spoon/support/compiler/jdt/ReferenceBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@
import org.eclipse.jdt.internal.compiler.lookup.SourceTypeBinding;
import org.eclipse.jdt.internal.compiler.lookup.TypeBinding;
import org.eclipse.jdt.internal.compiler.lookup.TypeVariableBinding;
import org.eclipse.jdt.internal.compiler.lookup.UnresolvedReferenceBinding;
import org.eclipse.jdt.internal.compiler.lookup.VariableBinding;
import org.eclipse.jdt.internal.compiler.lookup.VoidTypeBinding;
import org.eclipse.jdt.internal.compiler.lookup.WildcardBinding;
Expand Down Expand Up @@ -867,6 +868,8 @@ <T> CtTypeReference<T> getTypeReference(TypeBinding binding, boolean resolveGene
ref = getTypeReferenceFromProblemReferenceBinding((ProblemReferenceBinding) binding);
} else if (binding instanceof IntersectionTypeBinding18) {
ref = getTypeReferenceFromIntersectionTypeBinding((IntersectionTypeBinding18) binding);
} else if (binding instanceof UnresolvedReferenceBinding) {
ref = getTypeReferenceFromUnresolvedReferenceBinding((UnresolvedReferenceBinding) binding);
} else {
throw new RuntimeException("Unknown TypeBinding: " + binding.getClass() + " " + binding);
}
Expand All @@ -875,6 +878,25 @@ <T> CtTypeReference<T> getTypeReference(TypeBinding binding, boolean resolveGene
return (CtTypeReference<T>) ref;
}

/**
* Resolves a {@link UnresolvedReferenceBinding} to their closest match.
* For this we use the {@link UnresolvedReferenceBinding#closestMatch()} method. This is a best effort approach and can fail.
*
* @param binding the binding to resolve to a type reference.
* @return a type reference or null if the binding has no closest match
*/
@SuppressWarnings("ReturnOfNull")
private CtTypeReference<?> getTypeReferenceFromUnresolvedReferenceBinding(UnresolvedReferenceBinding binding) {
TypeBinding closestMatch = binding.closestMatch();
if (closestMatch != null) {
CtTypeReference<?> ref = this.jdtTreeBuilder.getFactory().Core().createTypeReference();
ref.setSimpleName(new String(binding.sourceName()));
ref.setPackage(getPackageReference(binding.getPackage()));
return ref;
}
return null;
}

private static boolean isParameterizedProblemReferenceBinding(TypeBinding binding) {
String sourceName = String.valueOf(binding.sourceName());
return binding instanceof ProblemReferenceBinding && typeRefContainsTypeArgs(sourceName);
Expand Down