review: fix: replace Infinity, NaN in reflection model with divisions #5445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SirYwell
changed the title
I-Al-Istannen
requested changes
Sep 10, 2023
Comment on lines
965
to
976
| Map.of( | ||
| "SpecialValues.java", | ||
| "public class SpecialValues {\n" + | ||
| " public static final double d_inf = 1.0d / 0.0d;\n" + | ||
| " public static final double d_m_inf = -1.0d / 0.0d;\n" + | ||
| " public static final double d_nan = 0.0d / 0.0d;\n" + | ||
| " public static final float f_inf = 1.0f / 0.0f;\n" + | ||
| " public static final float f_m_inf = -1.0f / 0.0f;\n" + | ||
| " public static final float f_nan = 0.0f / 0.0f;\n" + | ||
| "}\n" | ||
| ), | ||
| List.of() |
There was a problem hiding this comment.
Suggested change
| Map.of( | |
| "SpecialValues.java", | |
| "public class SpecialValues {\n" + | |
| " public static final double d_inf = 1.0d / 0.0d;\n" + | |
| " public static final double d_m_inf = -1.0d / 0.0d;\n" + | |
| " public static final double d_nan = 0.0d / 0.0d;\n" + | |
| " public static final float f_inf = 1.0f / 0.0f;\n" + | |
| " public static final float f_m_inf = -1.0f / 0.0f;\n" + | |
| " public static final float f_nan = 0.0f / 0.0f;\n" + | |
| "}\n" | |
| ), | |
| List.of() | |
| Map.of( | |
| "SpecialValues.java", | |
| "public class SpecialValues {\n" + | |
| " public static final double d_inf = 1.0d / 0.0d;\n" + | |
| " public static final double d_m_inf = -1.0d / 0.0d;\n" + | |
| " public static final double d_nan = 0.0d / 0.0d;\n" + | |
| " public static final float f_inf = 1.0f / 0.0f;\n" + | |
| " public static final float f_m_inf = -1.0f / 0.0f;\n" + | |
| " public static final float f_nan = 0.0f / 0.0f;\n" + | |
| "}\n" | |
| ), | |
| List.of() |
I-Al-Istannen
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5429.
(-)Infinity and NaN are no valid literals, but the reflection model previously built such literals, causing exceptions when printing them.
By representing those values by suitable divisions, we can still represent them in the model (as it is done in e.g.
java.lang.Double).